feat: add --require-unique-paramset-ids option skips pytest internal …

[gomri15]

• Added flag to skip attempting to generate parametrization ids and just raise error on duplicate ids during collection

Closes #13737

[Zac-HD]

Should i documentation like there is for --collect-only?

Yes please - and then I think we'll be ready to merge 🙂

[gomri15]

Should i documentation like there is for --collect-only?

Yes please - and then I think we'll be ready to merge 🙂

Is this till needed or did with @nicoddemus say cover this?

[gomri15]

Done all fixes

[nicoddemus]

@Zac-HD just realized something: doesn't make more sense for this to be an ini option rather than a command-line flag? I understand this is something one would like to setup permanently for a test suite, rather than something to be passed on the command line on occasion.

[Zac-HD]

doesn't make more sense for this to be an ini option rather than a command-line flag?

Ideally both, I guess?

[gomri15]

doesn't make more sense for this to be an ini option rather than a command-line flag?

Ideally both, I guess?

@nicoddemus, @Zac-HD
added support for the ini flag and tests for it.

[gomri15]

@nicoddemus, @Zac-HD I've addressed all issues and added support both as ini and cli param would love to try get this over line

[Zac-HD]

Minor edits to the docs, and then I'll give @nicoddemus a few days to comment, and then merge!

[bluetech]

just realized something: doesn't make more sense for this to be an ini option rather than a command-line flag? I understand this is something one would like to setup permanently for a test suite, rather than something to be passed on the command line on occasion.

FWIW I agree with this, I don't see a reason for this to be a CLI flag, only ini. Having fewer flags is generally a good thing.

In the future we could also consider adding it to the planned strict setting. A while ago we deprecated and removed strict with the intention of re-adding it such that it enabled various "strict" options, like this one. Though I do reckon that if we add it it should be as an INI flag not CLI.

[gomri15]

I understand wanting to have fewer flags to reduce complexity and setup pain.

Because we can get the same results from an ini and most likely, this parameter wills be set at the level of the whole execution and not just a few tests being run

Would you like me to remove the cli flag oart of this pr and leave the ini?

[bluetech]

Some comments from me. I think this can be a nice strictness flag.

[bluetech]

Thanks for the input bluetech, would you like me to remove the cli flag oart of this pr and leave the ini?

I'll let @Zac-HD decide, I don't feel strongly about it.

[gomri15]

@bluetech I went over and fixed all your comments, thanks for the input.

Main changes made:

• rename flag to - "require-unique-parameterization-ids" i agree it's much more readable and would be easier for pytest users to understand
• Added fix suggestion to error message (it might be too explicit, but I was thinking it would be nice for the message to be a one stop shop for solving the problem)
• Inlined testing until function which called create testfile
• Improved wording of description for clarity.

[bluetech]

Thanks for the update! Please see my comments below.

[bluetech]

Thanks for the input bluetech, would you like me to remove the cli flag oart of this pr and leave the ini?

I'll let @Zac-HD decide, I don't feel strongly about it.

BTW, if we go with ini only, I think it would make sense to use the name strict_parametrization_ids or such, similar to strict_xfail, to indicate it's a strictness flag. And if in the future we add the strict ini it'd be clear that it's part of it.