Skip to content

terminal: disable OSC 9;4; terminal progress by default, except on Windows #13971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 20, 2025
Merged

terminal: disable OSC 9;4; terminal progress by default, except on Windows #13971

merged 3 commits into from
Nov 20, 2025
+89 −40

Conversation

@bluetech
Copy link
Member

@bluetech bluetech commented Nov 16, 2025 •
edited
Loading

Fix #13896.
Fix #13972.

Replaces #13967, see discussion there for some more context.

@bluetech bluetech added the backport 9.0.x apply to PRs at any point; backports the changes to the 9.0.x branch label Nov 16, 2025
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Nov 16, 2025
@bluetech bluetech force-pushed the disable-terminalprogress-by-default2 branch from 8cb26ed to 9c9bef2 Compare November 16, 2025 14:54
@bluetech bluetech mentioned this pull request Nov 18, 2025
Closed
@bluetech bluetech force-pushed the disable-terminalprogress-by-default2 branch from 9c9bef2 to f95155b Compare November 18, 2025 18:57
@bluetech
Copy link
Member Author

bluetech commented Nov 18, 2025

I added two commits: some test mocking cleanup, and a fix to disable when TERM=dumb (resolves #13972).

nicoddemus
nicoddemus approved these changes Nov 19, 2025
View reviewed changes
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for tackling this solution.

@henryiii
Copy link

henryiii commented Nov 19, 2025 •
edited
Loading

iTerm now supports it!

Screen.Recording.2025-11-19.at.12.33.20.PM.mov

(not disagreeing with this solution, by the way; this makes it possible, though opt-in, to show them on iTerm. Just pointing out the macOS problem has been fixed, and users will likely be asked to upgrade like I was, so the macOS issue is going away hopefully pretty quickly.)

@bluetech
Copy link
Member Author

bluetech commented Nov 20, 2025

@henryiii Nice! Hopefully we can re-enable it by default in a few releases.

@bluetech bluetech force-pushed the disable-terminalprogress-by-default2 branch from f95155b to 992dc7f Compare November 20, 2025 14:59
@bluetech bluetech mentioned this pull request Nov 20, 2025
Closed
@bluetech
terminal: disable OSC 9;4; terminal progress by default, except on Wi…
2ffef56 
…ndows

Fix pytest-dev#13896.
@bluetech
testing: improve mocking in terminalprogress tests
6d6ae27
@bluetech
terminalprogress: disable when TERM=dumb
beedab9 
TERM=dumb shouldn't emit escape codes like terminalprogress does, it
would likely come out as literal escape characters.
@bluetech bluetech force-pushed the disable-terminalprogress-by-default2 branch from 992dc7f to beedab9 Compare November 20, 2025 21:03
@bluetech bluetech merged commit 66834f3 into pytest-dev:main Nov 20, 2025
33 checks passed
@bluetech bluetech deleted the disable-terminalprogress-by-default2 branch November 20, 2025 21:42
@patchback
Copy link

patchback bot commented Nov 20, 2025 •
edited
Loading

Backport to 9.0.x: 💚 backport PR created

✅ Backport PR branch: patchback/backports/9.0.x/66834f362e38e96eb7685e21f46bdb83ba52530b/pr-13971

Backported as #13990

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 20, 2025
@bluetech @patchback
Merge pull request #13971 from bluetech/disable-terminalprogress-by-d…
1c27999 
…efault2

terminal: disable OSC 9;4; terminal progress by default, except on Windows
(cherry picked from commit 66834f3)
@patchback patchback bot mentioned this pull request Nov 20, 2025
Merged
bluetech added a commit that referenced this pull request Nov 20, 2025
@bluetech
Merge pull request #13990 from pytest-dev/patchback/backports/9.0.x/6…
b229efb 
…6834f362e38e96eb7685e21f46bdb83ba52530b/pr-13971

[PR #13971/66834f36 backport][9.0.x] terminal: disable OSC 9;4; terminal progress by default, except on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees

No one assigned

Labels

backport 9.0.x apply to PRs at any point; backports the changes to the 9.0.x branch bot:chronographer:provided (automation) changelog entry is part of PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9.0.0 outputs control characters with '---color=no' terminalprogress causes thousands of iTerm2 alerts

3 participants

@bluetech @henryiii @nicoddemus