-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sphinx doc #202
base: master
Are you sure you want to change the base?
Add sphinx doc #202
Conversation
From my point of view, this version would be ready for merging. |
1dd6c66
to
26fd2b0
Compare
doc/conf.py
Outdated
project = 'Slycot' | ||
copyright = '2023, Slycot Developers' | ||
author = 'Slycot Developers' | ||
release = '0.6' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be automated to look at the git tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could use the code from python-control. Would that be enough?
# Version information - read from the source code
import re
# Get the version number for this commmit (including alpha/beta/rc tags)
release = re.sub('^v', '', os.popen('git describe').read().strip())
# The short X.Y.Z version
version = re.sub(r'(\d+\.\d+\.\d+(.post\d+)?)(.*)', r'\1', release)
print("version %s, release %s" % (version, release))
.. autosummary:: | ||
:toctree: generated/ | ||
|
||
ab01nd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So wee need to add entries here for every additional wrapper? Better write a check that we don't forget anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I also thought about that.
There is a python script /doc/create_names_for_reference.py
that generates all routine names of
slycot
and slycot._wrapper
.
I think there are 2 options:
- a script that compares the output from the script above with the routine names found in
slycot_outer.rst
andslycot_inner.rst
. - a script that generates the whole files of
slycot_outer.rst
andslycot_inner.rst
.
I have to look into that.
26fd2b0
to
0e79a27
Compare
c327620
to
fb26217
Compare
Do we need a sphinx workflow in the .github actions in order to check results? |
To be honest, I don't have much experience with github actions and don't know what is possible. Currently I'm thinking about some kind of slycot-analyzer that analyzes the slycot and slicot-reference modules, generates statistics and checks for some completeness. I would put this "slycot-analyzer" under slycot/doc/slycot-analyzer. github actions could call some functions of a "slycot-analyzer". Currently there are some python/notebook files:
For now, though, I'll focus on the docstring and numpydocs. |
4b2dc1e
to
396f287
Compare
e903744
to
9815526
Compare
9815526
to
9b6b178
Compare
This PR adds a sphinx documentation. The doc includes an introduction, API reference, developer info and examples.