-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ab09hd and tg01gd, and show that n,m,p can be removed #225
base: master
Are you sure you want to change the base?
Conversation
Thank you very much for your enthusiasm and work on Slycot.
|
@@ -10,5 +10,7 @@ build.log | |||
*.egg-info/ | |||
.coverage | |||
*~ | |||
.#* | |||
.*~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.*~
This is already covered by *~
What kind of tool creates files with #
in it?
A[..., :nr, :nr], | ||
E[..., :nr, :nr], | ||
B[..., :nr, :], | ||
C[..., :, :nr], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the leading ...
parts. The wrapper only returns two-dimensional arrays.
Hi all,
I wanted to test using ab09hd as it can ensure relative error during reduction. Additionally, tg01gd is useful for maintaining descriptor systems and reducing them back to a standard form. I've added wrappers and python interfaces. It's less work if you are willing to pull directly, but I could split this into separate PR's. The docstrings are possibly too much of a copy of the slicot documentation?
Additionally, I added an auxiliary wrapper for ab09nd that adjusts the dependency resolution between n,m,p and a,b,c. This is a general technique that can allow the n,m,p arguments to be dropped from any/all of the wrappers. I know this changes the interface, since n,m,p are exposed to the external API, even though they could all be determined from the python-side wrappers anyway. Including it since I already tested it, and it may be of some interest to simplify the interfaces.