Skip to content

Python 3.13 upgrade #3352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 28, 2025
Merged

Python 3.13 upgrade #3352

merged 3 commits into from
Jul 28, 2025

Conversation

jb3
Copy link
Member

@jb3 jb3 commented Jul 27, 2025

Upgrades Dockerfile & pyproject.toml to use 3.13.

Tested locally, bot starts without issue.

@jb3 jb3 requested a review from MarkKoz as a code owner July 27, 2025 13:14
@python-discord-policy-bot python-discord-policy-bot bot requested a review from a team July 27, 2025 13:14
Copy link
Member

@ChrisLovering ChrisLovering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target-version in the linting section of pyproject needs updating too, but looks good

@jb3 jb3 force-pushed the jb3/3.13-upgrade branch from b50abfa to d42680f Compare July 27, 2025 13:41
Copy link
Contributor

@wookie184 wookie184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some new warnings in the test CI

tests/bot/exts/test_cogs.py::CommandNameTests::test_names_dont_shadow
  /home/runner/work/bot/bot/bot/exts/utils/extensions.py:29: FutureWarning: functools.partial will be a method descriptor in future Python versions; wrap it in enum.member() if you want to preserve the old behavior
    RELOAD = functools.partial(Bot.reload_extension)

The fix should be the same as for lancebot python-discord/sir-lancebot@2a42669

@jb3 jb3 requested a review from wookie184 July 28, 2025 20:46
@jb3 jb3 merged commit 1546ba6 into main Jul 28, 2025
7 checks passed
@jb3 jb3 deleted the jb3/3.13-upgrade branch July 28, 2025 23:21
@jb3 jb3 deployed to production July 28, 2025 23:22 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants