Skip to content

Conversation

egbutter
Copy link

@egbutter egbutter commented May 1, 2020

Pull Request Check List

Addresses bug #467. Adding try/except workaround in local_timezone.py and test for the environment variable functionality. When pendulum incorrectly tries to treat an environment variable local timezone as a filepath instead of a string, carry on and try to treat the string as a timezone itself, instead.

  • Added tests for changed code - one new test illustrating env var behavior, asserting it still works
  • Updated documentation for changed code - added a single-line comment explaining change, nothing to add to docs
  • Based on master because this is a bugfix for current production pendulum==2.1.0

egbutter added 2 commits May 1, 2020 17:36
…d the same as the timezone exists, attempts to read it as a file even if it is not a timezone file
@egbutter egbutter changed the title Eeb/test env var local tz Adding try/except workaround when Pendulum tries to treat environment variable local timezone as a filepath May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant