-
Notifications
You must be signed in to change notification settings - Fork 6
Add logging to TAP file #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
add diagnostics to ok tests
for more information, see https://pre-commit.ci
@mblayman Could I get a review on this? I can't seem to request reviewers on this repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty decent to me. Config options are forever, practically, so I'd like to avoid adding one of these.
for more information, see https://pre-commit.ci
…into add-logging
for more information, see https://pre-commit.ci
Believe it is ready to re-review. Some concern as the default behavior in pytest is for I'm also considering to make these |
I'm not concerned. The library makes no promises about what diagnostics it outputs. This configuration lines up with the default pytest behavior, which feels good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! 👍
resolves #91
This is based off the existing pytest JUnit logging support.
NOTE: Have PR to add logging to passing tests, but that requires an update to tappy.
tappy PR - python-tap/tappy#148
pytest-tap PR - codambro#1
To accept your contribution, please complete the checklist below.