Refactor get_build_backend_hook_caller() API #574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the `get_build_backend_hook_caller()` helper to align with other APIs. The function now takes a `ctx` and `req` parameter like most other functions. The `sdist_root_dir` parameter was misleading, because the function actually requires the `build_dir` with `pyproject.toml`. The argument has been renamed to `build_dir`. `pyproject.toml` content and `network_isolation` parameter are handled internally, too. Signed-off-by: Christian Heimes <[email protected]>
tiran
force-pushed
the
refactor-hook-caller
branch
from
49c4ebe to
d295758
Compare
dhellmann
approved these changes
Apr 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the
get_build_backend_hook_caller()helper to align with other APIs. The function now takes actxandreqparameter like most other functions. Thesdist_root_dirparameter was misleading, because the function actually requires thebuild_dirwithpyproject.toml. The argument has been renamed tobuild_dir.pyproject.tomlcontent andnetwork_isolationparameter are handled internally, too.