Skip to content

GH-121970: Use SphinxDirective instead of Directive #121972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2024
Merged

GH-121970: Use SphinxDirective instead of Directive #121972

merged 1 commit into from
Jul 19, 2024

Conversation

AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Jul 18, 2024 •
edited by github-actions bot
Loading

@AA-Turner AA-Turner added docs Documentation in the Doc dir skip news labels Jul 18, 2024
@bedevere-app bedevere-app bot mentioned this pull request Jul 18, 2024
Open
ezio-melotti
ezio-melotti reviewed Jul 18, 2024
View reviewed changes
Copy link
Member

@ezio-melotti ezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look ok to me, even though I'm not familiar with SphinxDirective.

@AA-Turner AA-Turner added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jul 19, 2024
@AA-Turner AA-Turner merged commit ac39151 into python:main Jul 19, 2024
30 checks passed
@AA-Turner AA-Turner deleted the docs/sphinxdirective branch July 19, 2024 07:33
@miss-islington-app
Copy link

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2024
@AA-Turner @miss-islington
pythonGH-121970: Use SphinxDirective instead of Directive (py…
4070c51 
…thonGH-121972)

(cherry picked from commit ac39151)

Co-authored-by: Adam Turner <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 19, 2024
@AA-Turner @miss-islington
pythonGH-121970: Use SphinxDirective instead of Directive (py…
c8dc151 
…thonGH-121972)

(cherry picked from commit ac39151)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jul 19, 2024

GH-122008 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 19, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jul 19, 2024

GH-122009 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jul 19, 2024
AA-Turner added a commit that referenced this pull request Jul 19, 2024
@miss-islington @AA-Turner
[3.12] GH-121970: Use SphinxDirective instead of Directive (G…
1855784 
…H-121972) (#122009)

GH-121970: Use ``SphinxDirective`` instead of ``Directive`` (GH-121972)
(cherry picked from commit ac39151)

Co-authored-by: Adam Turner <[email protected]>
AA-Turner added a commit that referenced this pull request Jul 19, 2024
@miss-islington @AA-Turner
[3.13] GH-121970: Use SphinxDirective instead of Directive (G…
711c328 
…H-121972) (#122008)

GH-121970: Use ``SphinxDirective`` instead of ``Directive`` (GH-121972)
(cherry picked from commit ac39151)

Co-authored-by: Adam Turner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezio-melotti ezio-melotti ezio-melotti left review comments

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AA-Turner @ezio-melotti