Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-128923: fix test_pydoc for object subclasses without __module__ #128951

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

Yhg1s
Copy link
Member

@Yhg1s Yhg1s commented Jan 17, 2025

Fix pydoc's docclass() for classes inheriting from object without the __module__ attribute, like _testcapi.HeapType.

`__module__` attribute, like `_testcapi.HeapType`.
@Yhg1s Yhg1s marked this pull request as ready for review January 17, 2025 16:52
@Yhg1s Yhg1s added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 17, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @Yhg1s for commit ce3ac55 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 17, 2025
@Yhg1s
Copy link
Member Author

Yhg1s commented Jan 17, 2025

The android/iOS buildbots are indeed fixed by this, and the other reported buildbot failures are not caused by this PR (nor the original PR).

@Yhg1s Yhg1s requested review from colesbury and picnixz January 17, 2025 22:11
@Yhg1s Yhg1s merged commit d4544cb into python:main Jan 17, 2025
110 of 121 checks passed
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 21, 2025
…le__` (python#128951)

Fix pydoc's docclass() for classes inheriting from object without the `__module__` attribute, like `_testcapi.HeapType`.
@Yhg1s Yhg1s deleted the fix_pydoc_builtins branch January 21, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants