gh-128770: raise warnings as errors in test suite - except for test_socket which still logs warnings, and internal test warnings that are now logged #128973

graingert · 2025-01-18T08:48:50Z

Issue: configure warnings as errors in the test suite #128770

…cept for test_socket which still logs warnings (python#128726)" (python#128936) This reverts commit 76856ae.

Lib/test/support/os_helper.py

graingert · 2025-01-18T10:32:52Z

@hugovk can I get a run on the buildbots for this PR?

hugovk · 2025-01-18T16:53:51Z

Certainly!

Let's check if you can do it yourself: either apply one of the test-with-buildbots or test-with-refleak-buildbots labels, or add a comment like ! buildbot optional-regex (but no space between exclamation mark and buildbot) to run a subset.

bedevere-bot · 2025-01-18T18:05:12Z

🤖 New build scheduled with the buildbot fleet by @graingert for commit c06c3db 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

bedevere-bot · 2025-01-18T19:36:05Z

🤖 New build scheduled with the buildbot fleet by @graingert for commit 7123093 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

graingert · 2025-01-18T19:37:03Z

@hugovk do you know where I can see the status?

hugovk · 2025-01-18T20:56:41Z

You can click the "Details" links in the status checks:

Some of those failing ones were already failing for previous builds, so aren't necessarily caused by this PR.

graingert · 2025-01-18T21:06:43Z

You can click the "Details" links in the status checks:

Some of those failing ones were already failing for previous builds, so aren't necessarily caused by this PR.

Ah those hadn't shown up yet

…oroutineTest.test_17

hugovk · 2025-03-27T09:49:33Z

The warnings have been fixed in other PRs in main, and this PR is back to turning future warnings into errors. If there are no objections, I'll merge this later today.

miss-islington-app · 2025-03-27T19:07:01Z

Thanks @graingert for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington-app · 2025-03-27T19:07:07Z

Sorry, @graingert and @hugovk, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 8a00c9a4d2ce9d373b13f8f0a2265a65f4523293 3.13

miss-islington-app · 2025-03-27T19:07:11Z

Sorry, @graingert and @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 8a00c9a4d2ce9d373b13f8f0a2265a65f4523293 3.12

bedevere-app · 2025-03-27T19:58:34Z

GH-131802 is a backport of this pull request to the 3.13 branch.

…test_socket which still logs warnings, and internal test warnings that are now logged (python#128973) Co-authored-by: Bénédikt Tran <[email protected]> (cherry picked from commit 8a00c9a)

bedevere-bot · 2025-03-27T20:20:19Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Fedora Stable LTO 3.x (tier-2) has failed when building commit 8a00c9a.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/336/builds/6580) and take a look at the build logs.
Check if the failure is related to this commit (8a00c9a) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/336/builds/6580

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/threading.py", line 1054, in _bootstrap_inner
    self.run()
    ~~~~~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/threading.py", line 996, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/test/test_interpreters/test_stress.py", line 30, in task
    interp = interpreters.create()
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/test/support/interpreters/__init__.py", line 76, in create
    id = _interpreters.create(reqrefs=True)
interpreters.InterpreterError: interpreter creation failed
k


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/threading.py", line 1054, in _bootstrap_inner
    self.run()
    ~~~~~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/threading.py", line 996, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/test/test_interpreters/test_stress.py", line 47, in run
    interp = interpreters.create()
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/test/support/interpreters/__init__.py", line 76, in create
    id = _interpreters.create(reqrefs=True)
interpreters.InterpreterError: interpreter creation failed
k

graingert · 2025-03-27T20:41:41Z

the failure is related to this commit, however the code in this PR is working as intended. This has uncovered an issue in subinterpreters:

test_create_many_threaded (test.test_interpreters.test_stress.StressTests.test_create_many_threaded) ... Warning -- Uncaught thread exception: InterpreterError
Exception in thread Thread-166 (task):
RuntimeError: Failed to import encodings module
During handling of the above exception, another exception occurred:
interpreters.InterpreterError: sub-interpreter creation failed
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/threading.py", line 1054, in _bootstrap_inner
    self.run()
    ~~~~~~~~^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/threading.py", line 996, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/test/test_interpreters/test_stress.py", line 30, in task
    interp = interpreters.create()
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto/build/Lib/test/support/interpreters/__init__.py", line 76, in create
    id = _interpreters.create(reqrefs=True)
interpreters.InterpreterError: interpreter creation failed

ZeroIntensity · 2025-03-27T22:46:41Z

That's a known failure, don't worry about it.

graingert · 2025-03-27T22:51:45Z

Ah you're right it's not a Warning that got raised as an Exception! I panicked like the message said not to

bedevere-app · 2025-03-28T07:54:54Z

GH-131824 is a backport of this pull request to the 3.12 branch.

…test_socket which still logs warnings, and internal test warnings that are now logged (python#128973) Co-authored-by: Bénédikt Tran <[email protected]>

graingert added 2 commits January 18, 2025 08:26

Reapply "pythongh-128770: raise warnings as errors in test suite - ex…

a6bb15e

…cept for test_socket which still logs warnings (python#128726)" (python#128936) This reverts commit 76856ae.

convert internal test warnings into logger calls

baab6a3

bedevere-app bot mentioned this pull request Jan 18, 2025

configure warnings as errors in the test suite #128770

Open

graingert added the skip news label Jan 18, 2025

graingert commented Jan 18, 2025

View reviewed changes

Lib/test/support/os_helper.py Outdated Show resolved Hide resolved

graingert commented Jan 18, 2025

View reviewed changes

Lib/test/support/os_helper.py Show resolved Hide resolved

graingert commented Jan 18, 2025

View reviewed changes

Lib/test/support/os_helper.py Outdated Show resolved Hide resolved

graingert commented Jan 18, 2025

View reviewed changes

Lib/test/support/os_helper.py Show resolved Hide resolved

graingert added 3 commits January 18, 2025 08:52

Apply suggestions from code review

c933487

test that support logs instead of warns

9e532fa

Merge branch 'main' into warnings-as-error-2

c06c3db

graingert added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 18, 2025

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 18, 2025

graingert added 2 commits January 18, 2025 18:05

Merge branch 'main' into warnings-as-error-2

ba36dc0

Merge branch 'main' into warnings-as-error-2

7123093

graingert added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 18, 2025

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 18, 2025

Merge branch 'main' into warnings-as-error-2

33c84e6

graingert marked this pull request as ready for review January 18, 2025 22:48

graingert requested review from ericsnowcurrently, gpshead, tiran and picnixz as code owners January 18, 2025 22:48

graingert added 4 commits March 25, 2025 07:47

Merge branch 'main' into warnings-as-error-2

9f92698

pythongh-131707: fix unawaited coroutine warning in test_coroutines.C…

78ffa2a

…oroutineTest.test_17

Merge branch 'main' into warnings-as-error-2

009a6a0

Merge branch 'main' into warnings-as-error-2

4586652

hugovk approved these changes Mar 25, 2025

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting review labels Mar 25, 2025

graingert added 3 commits March 26, 2025 08:25

Merge branch 'main' into warnings-as-error-2

e0479be

Merge branch 'main' into warnings-as-error-2

a656a68

Merge branch 'main' into warnings-as-error-2

f27d4a7

hugovk merged commit 8a00c9a into python:main Mar 27, 2025
46 checks passed

bedevere-app bot removed the awaiting merge label Mar 27, 2025

miss-islington-app bot assigned hugovk Mar 27, 2025

graingert deleted the warnings-as-error-2 branch March 27, 2025 19:22

graingert mentioned this pull request Mar 27, 2025

[3.13] gh-128770: raise warnings as errors in test suite - except for test_s… #131802

Merged

bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 27, 2025

graingert mentioned this pull request Mar 28, 2025

[3.12] gh-128770: raise warnings as errors in test suite - except for test_s… #131824

Open

bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Mar 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gh-128770: raise warnings as errors in test suite - except for test_socket which still logs warnings, and internal test warnings that are now logged #128973

gh-128770: raise warnings as errors in test suite - except for test_socket which still logs warnings, and internal test warnings that are now logged #128973

graingert commented Jan 18, 2025 •

edited by bedevere-app bot

Loading

graingert commented Jan 18, 2025

hugovk commented Jan 18, 2025

bedevere-bot commented Jan 18, 2025

bedevere-bot commented Jan 18, 2025

graingert commented Jan 18, 2025

hugovk commented Jan 18, 2025

graingert commented Jan 18, 2025

hugovk commented Mar 27, 2025

miss-islington-app bot commented Mar 27, 2025

miss-islington-app bot commented Mar 27, 2025

miss-islington-app bot commented Mar 27, 2025

bedevere-app bot commented Mar 27, 2025

bedevere-bot commented Mar 27, 2025

graingert commented Mar 27, 2025

ZeroIntensity commented Mar 27, 2025

graingert commented Mar 27, 2025

bedevere-app bot commented Mar 28, 2025

gh-128770: raise warnings as errors in test suite - except for test_socket which still logs warnings, and internal test warnings that are now logged #128973

gh-128770: raise warnings as errors in test suite - except for test_socket which still logs warnings, and internal test warnings that are now logged #128973

Conversation

graingert commented Jan 18, 2025 • edited by bedevere-app bot Loading

graingert commented Jan 18, 2025

hugovk commented Jan 18, 2025

bedevere-bot commented Jan 18, 2025

bedevere-bot commented Jan 18, 2025

graingert commented Jan 18, 2025

hugovk commented Jan 18, 2025

graingert commented Jan 18, 2025

hugovk commented Mar 27, 2025

miss-islington-app bot commented Mar 27, 2025

miss-islington-app bot commented Mar 27, 2025

miss-islington-app bot commented Mar 27, 2025

bedevere-app bot commented Mar 27, 2025

bedevere-bot commented Mar 27, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

graingert commented Mar 27, 2025

ZeroIntensity commented Mar 27, 2025

graingert commented Mar 27, 2025

bedevere-app bot commented Mar 28, 2025

graingert commented Jan 18, 2025 •

edited by bedevere-app bot

Loading