Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-127146: Fix Emscripten test suite when run with -uall #132092

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Lib/test/test_builtin.py
Original file line number Diff line number Diff line change
Expand Up @@ -1104,6 +1104,7 @@ def test_filter_pickle(self):
self.check_iter_pickle(f1, list(f2), proto)

@support.skip_wasi_stack_overflow()
@support.skip_emscripten_stack_overflow()
@support.requires_resource('cpu')
def test_filter_dealloc(self):
# Tests recursive deallocation of nested filter objects using the
Expand Down
2 changes: 2 additions & 0 deletions Lib/test/test_capi/test_misc.py
Original file line number Diff line number Diff line change
Expand Up @@ -411,10 +411,12 @@ def test_trashcan_subclass(self):
for i in range(100):
L = MyList((L,))

@support.skip_emscripten_stack_overflow()
@support.requires_resource('cpu')
def test_trashcan_python_class1(self):
self.do_test_trashcan_python_class(list)

@support.skip_emscripten_stack_overflow()
@support.requires_resource('cpu')
def test_trashcan_python_class2(self):
from _testcapi import MyList
Expand Down
1 change: 1 addition & 0 deletions Lib/test/test_descr.py
Original file line number Diff line number Diff line change
Expand Up @@ -4519,6 +4519,7 @@ class Oops(object):
o.whatever = Provoker(o)
del o

@support.skip_emscripten_stack_overflow()
@support.skip_wasi_stack_overflow()
@support.requires_resource('cpu')
def test_wrapper_segfault(self):
Expand Down
1 change: 1 addition & 0 deletions Lib/test/test_exceptions.py
Original file line number Diff line number Diff line change
Expand Up @@ -1428,6 +1428,7 @@ def g():
self.assertIsInstance(exc, RecursionError, type(exc))
self.assertIn("maximum recursion depth exceeded", str(exc))

@support.skip_emscripten_stack_overflow()
@support.skip_wasi_stack_overflow()
@cpython_only
@support.requires_resource('cpu')
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_io.py
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,7 @@ def do_test(test, obj, abilities):
for [test, abilities] in tests:
with self.subTest(test):
if test == pipe_writer and not threading_helper.can_start_thread:
skipTest()
self.skipTest("Requires threading but threading not supported")
with test() as obj:
do_test(test, obj, abilities)

Expand Down
4 changes: 4 additions & 0 deletions Lib/test/test_os.py
Original file line number Diff line number Diff line change
Expand Up @@ -1915,6 +1915,10 @@ def test_makedir(self):
'dir5', 'dir6')
os.makedirs(path)

@unittest.skipIf(
support.is_emscripten,
"Failing in the buildbot, but I can't reproduce. TODO: investigate this."
)
@unittest.skipIf(
support.is_wasi,
"WASI's umask is a stub."
Expand Down
4 changes: 2 additions & 2 deletions Lib/test/test_sysconfig.py
Original file line number Diff line number Diff line change
Expand Up @@ -659,8 +659,8 @@ def test_sysconfigdata_json(self):
ignore_keys |= {'prefix', 'exec_prefix', 'base', 'platbase', 'installed_base', 'installed_platbase'}

for key in ignore_keys:
json_config_vars.pop(key)
system_config_vars.pop(key)
json_config_vars.pop(key, None)
system_config_vars.pop(key, None)

self.assertEqual(system_config_vars, json_config_vars)

Expand Down
7 changes: 0 additions & 7 deletions configure

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -3158,10 +3158,6 @@ if test "$ac_cv_sizeof_off_t" -gt "$ac_cv_sizeof_long" -a \
else
have_largefile_support="no"
fi
dnl LFS does not work with Emscripten 3.1
AS_CASE([$ac_sys_system],
[Emscripten], [have_largefile_support="no"]
)
AS_VAR_IF([have_largefile_support], [yes], [
AC_DEFINE([HAVE_LARGEFILE_SUPPORT], [1],
[Defined to enable large file support when an off_t is bigger than a long
Expand Down
Loading