gh-132113: Make EnvironmentVarGuard thread safe
#132128
Open
+36
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks related to #132113 - can you add the issue number to the title? edit: re "Please do not review yet", you can mark this PR as a draft by clicking the "Convert to draft" button under "Reviewers" in the right-hand column |
srinivasreddy
changed the title
EnvironmentVarGuard thread safeEnvironmentVarGuard thread safe
srinivasreddy
force-pushed
the
thread_safe_env_var_guard
branch
from
fbe6202 to
a8a295f
Compare
|
Could you add a news entry? thanks! |
|
All commit authors signed the Contributor License Agreement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test.support.os_helper.EnvironmentVarGuardis not thread safe #132113