-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
gh-77393: Add --statistics
opt to msgfmt.py
#132136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
StanFromIreland
wants to merge
7
commits into
python:main
Choose a base branch
from
StanFromIreland:msgfmt-stat
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d5deb58
Add --statistics opt
StanFromIreland 3a9d5e2
Make it like GNU msgfmt's option
StanFromIreland e85a61a
Minor fix
StanFromIreland 898204b
Test multiple input files, also edge case (and as a result issue 5395…
StanFromIreland 0b71e6e
Add filenames for multiple inputs and fix test for windows
StanFromIreland 3c9fd26
Fix empty translation counting
StanFromIreland 3a97d43
Serhiy's suggestions
StanFromIreland File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -169,6 +169,17 @@ def test_no_input_file(self): | |
def test_nonexistent_file(self): | ||
assert_python_failure(msgfmt, 'nonexistent.po') | ||
|
||
def test_statistics(self): | ||
with temp_cwd(): | ||
res = assert_python_ok(msgfmt, '--statistics', data_dir / "general.po") | ||
out = res.out.decode('utf-8').strip() | ||
self.assertEqual('8 translated messages, 1 untranslated message.', out) | ||
# Multiple input files | ||
res = assert_python_ok(msgfmt, '--statistics', '-o', 'temp.mo', data_dir / "general.po", data_dir / "fuzzy.po") | ||
out = res.out.decode('utf-8').strip() | ||
self.assertIn('general.po: 8 translated messages, 1 untranslated message.', out) | ||
self.assertIn('fuzzy.po: 0 translated messages.', out) | ||
Comment on lines
+177
to
+181
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also a test for #53950 :-) Do we want a separate test too? |
||
|
||
|
||
def update_catalog_snapshots(): | ||
for po_file in data_dir.glob('*.po'): | ||
|
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/Tools-Demos/2025-04-05-18-13-00.gh-issue-77393.msgid28.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Added ``--statistics`` option to :program:`msgfmt`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.