Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dead hyperlink for CGI environment variables #132137

Merged
merged 2 commits into from
Apr 6, 2025

Conversation

srinivasreddy
Copy link
Contributor

No description provided.

@picnixz
Copy link
Member

picnixz commented Apr 5, 2025

I don't think it's really necessary. People who want to look up that reference would anyway use web.archive.org or wayback machine, so I'm not sure it's necessary to make that change (considering we're now exceeding the 80 chars limit). In addition, the CGI interface is going to be removed soon so this part of the code will be gone. However, we could perhaps find a non-dead link that lists the env. vars?

@srinivasreddy srinivasreddy changed the title Use web.archive.org url since server's IP address cannot be found Replaced dead hyperlink about CGI env variables Apr 5, 2025
@srinivasreddy srinivasreddy changed the title Replaced dead hyperlink about CGI env variables Replace dead hyperlink for CGI environment variables Apr 5, 2025
@srinivasreddy
Copy link
Contributor Author

@picnixz Fantastic. Done.

@picnixz picnixz self-assigned this Apr 5, 2025
@picnixz
Copy link
Member

picnixz commented Apr 5, 2025

I'll merge this tomorrow as well.

@hugovk hugovk added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Apr 6, 2025
@picnixz picnixz merged commit 0a10b45 into python:main Apr 6, 2025
46 checks passed
@miss-islington-app
Copy link

Thanks @srinivasreddy for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@picnixz
Copy link
Member

picnixz commented Apr 6, 2025

Thanks for the PR!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 6, 2025
…132137)

(cherry picked from commit 0a10b45dd16a8c971363d917b9ebd1266e65f710)

Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్  రెడ్డి) <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 6, 2025
…132137)

(cherry picked from commit 0a10b45)

Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్  రెడ్డి) <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Apr 6, 2025

GH-132150 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 6, 2025
@bedevere-app
Copy link

bedevere-app bot commented Apr 6, 2025

GH-132151 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Apr 6, 2025
picnixz pushed a commit that referenced this pull request Apr 6, 2025
…-132137) (#132151)

Docs: Replace dead hyperlink for CGI environment variables (GH-132137)
(cherry picked from commit 0a10b45)

Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్  రెడ్డి) <[email protected]>
picnixz pushed a commit that referenced this pull request Apr 6, 2025
…-132137) (#132150)

Docs: Replace dead hyperlink for CGI environment variables (GH-132137)
(cherry picked from commit 0a10b45)

Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్  రెడ్డి) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants