Skip to content

gh-96491: Deduplicate version in IDLE shell title #139841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 11, 2025
Merged

gh-96491: Deduplicate version in IDLE shell title #139841

merged 6 commits into from
Oct 11, 2025
+10 −5

Conversation

StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Oct 9, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Oct 9, 2025
Closed
terryjreedy
terryjreedy previously requested changes Oct 10, 2025
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my new issue comment for some explanation.

@bedevere-app
Copy link

bedevere-app bot commented Oct 10, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@StanFromIreland
Copy link
Member Author

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Oct 10, 2025

Thanks for making the requested changes!

@terryjreedy: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from terryjreedy October 10, 2025 15:35
terryjreedy
terryjreedy reviewed Oct 10, 2025
View reviewed changes
@terryjreedy terryjreedy dismissed their stale review October 10, 2025 22:49

Changes made.

@terryjreedy terryjreedy added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Oct 10, 2025
@terryjreedy terryjreedy merged commit d4e5802 into python:main Oct 11, 2025
52 of 53 checks passed
@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 11, 2025
@StanFromIreland @terryjreedy @miss-islington
pythongh-96491: Deduplicate version in IDLE shell title (pythonGH-139841
3f06738 
)

Saving to a file added both the filename and repeated the version.
---------
(cherry picked from commit d4e5802)

Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Terry Jan Reedy <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 11, 2025
@StanFromIreland @terryjreedy @miss-islington
pythongh-96491: Deduplicate version in IDLE shell title (pythonGH-139841
187dc41 
)

Saving to a file added both the filename and repeated the version.
---------
(cherry picked from commit d4e5802)

Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Terry Jan Reedy <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 11, 2025

GH-139931 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Oct 11, 2025
@bedevere-app
Copy link

bedevere-app bot commented Oct 11, 2025

GH-139932 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 11, 2025
terryjreedy added a commit that referenced this pull request Oct 11, 2025
@miss-islington @StanFromIreland @terryjreedy
[3.13] gh-96491: Deduplicate version in IDLE shell title (GH-139841) (#…
6a9908e 
…139932)

gh-96491: Deduplicate version in IDLE shell title (GH-139841)

Saving to a file added both the filename and repeated the version.
---------
(cherry picked from commit d4e5802)

Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Terry Jan Reedy <[email protected]>
terryjreedy added a commit that referenced this pull request Oct 11, 2025
@miss-islington @StanFromIreland @terryjreedy
[3.14] gh-96491: Deduplicate version in IDLE shell title (GH-139841) (#…
1a355d7 
…139931)

gh-96491: Deduplicate version in IDLE shell title (GH-139841)

Saving to a file added both the filename and repeated the version.
---------
(cherry picked from commit d4e5802)

Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Terry Jan Reedy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StanFromIreland @terryjreedy