-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
bpo-43570: Doc: Fix i18n issue with audit hooks. #24945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I wanted to confirm here that this patch makes the Spanish translation to work as well. I didn't dig too much on the HTML generated yet, but at least Sphinx finishes with no warning at all with this patch. We found the same problem in our translation and we are tracking it at python/python-docs-es#1221 |
I tried running -#: library/sys.rst:1246
-msgid ""
-"Raises an :ref:`auditing event <auditing>` ``sys.setprofile`` with no "
-"arguments."
-msgstr ""
-"Lève un :ref:`évènement d'audit <auditing>` ``sys.setprofile`` sans "
-"arguments."
-
#: library/sys.rst:1329
msgid "The events have the following meaning:"
msgstr "Les événements ont la signification suivante :"
@@ -2659,13 +2657,6 @@ msgstr ""
"Pour plus d'informations sur les objets code et objets représentant une "
"*frame* de la pile, consultez :ref:`types`."
-#: library/sys.rst:1380
-msgid ""
-"Raises an :ref:`auditing event <auditing>` ``sys.settrace`` with no "
-"arguments."
-msgstr ""
-"Lève un :ref:`évènement d'audit <auditing>` ``sys.settrace`` sans arguments."
-
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you're done making the requested changes, leave the comment: |
f23a766
to
7985f1f
Compare
I have made the requested changes; please review again. |
Thanks for making the requested changes! @zooba: please review the changes made to this pull request. |
@humitos would you please check if this new patch works for the spanish translation? |
I And wow, I feel good, I understand my own patch (it was NOT the case for the previous one): As we translate restructuredtext, the rawsource (1rst parameter of |
Gentle ping @zooba. |
This PR is stale because it has been open for 30 days with no activity. |
I'm closing this as I want to see how #19470 will change all of this, before. I'll reopen if needed. |
https://bugs.python.org/issue43570