Skip to content

Use a config file. #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Oct 17, 2023
Merged

Use a config file. #143

merged 20 commits into from
Oct 17, 2023

Conversation

JulienPalard
Copy link
Member

Config was previously a bit hidden "in the middle" of the py file. I'd like to use toml but we have a Python 3.8 in production, I'll just wait.

ezio-melotti
ezio-melotti reviewed Jan 11, 2023
View reviewed changes
@JulienPalard JulienPalard force-pushed the config branch 2 times, most recently from ab65eee to 4065817 Compare October 12, 2023 08:23
@JulienPalard JulienPalard changed the title Use a config file. [WIP] Use a config file. Oct 12, 2023
@JulienPalard
Copy link
Member Author

It starts to work but now we lost the info if a release is pointed by a branch or by a tag, which was usefull to git reset to the right release.

@JulienPalard
Copy link
Member Author

OK using git show-ref I can easily find the related sha1 of a branch or a tag indiferentely.

I'm running a full build locally before merging.

@JulienPalard
Copy link
Member Author

OK I think this one is good, does someone want to review?

@JulienPalard JulienPalard changed the title [WIP] Use a config file. Use a config file. Oct 12, 2023
egeakman
egeakman reviewed Oct 13, 2023
View reviewed changes
AA-Turner
AA-Turner reviewed Oct 14, 2023
View reviewed changes
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A brief desk review:

m-aciek
m-aciek approved these changes Oct 14, 2023
View reviewed changes
@JulienPalard
Copy link
Member Author

Damned, git show-ref is ambiguous for the main branch as it may have a local existance:

$ git -C /home/mdk/clones/python/docsbuild-scripts/build_root/cpython show-ref main
72b0f0eaf52ac46d5f6e165f737d6f891cf8d172 refs/heads/main
fa18b0afe47615dbda15407a102b84e40cadf6a5 refs/remotes/origin/main

this can't be merged yet.

@JulienPalard JulienPalard merged commit 03e8f07 into python:main Oct 17, 2023
@JulienPalard JulienPalard deleted the config branch October 17, 2023 20:19
@JulienPalard JulienPalard mentioned this pull request Oct 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atsuoishimoto atsuoishimoto atsuoishimoto left review comments

@AA-Turner AA-Turner AA-Turner left review comments

@ezio-melotti ezio-melotti ezio-melotti left review comments

@egeakman egeakman egeakman left review comments

@m-aciek m-aciek m-aciek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JulienPalard @atsuoishimoto @AA-Turner @m-aciek @ezio-melotti @egeakman