Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ruff FURB None rules #18687

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Skylion007
Copy link
Contributor

We already abide by these rules in the codebase, might as well enforce them explicitly.

Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

Tanjun (https://github.com/FasterSpeeding/Tanjun): 1.69x faster (129.9s -> 77.1s in a single noisy sample)

django-stubs (https://github.com/typeddjango/django-stubs): 1.90x slower (25.1s -> 47.7s in a single noisy sample)

Copy link
Collaborator

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please just be careful when adding new ruff rules. I'd suggest to concentrate on those which provide a measurable benefit and ignore the subjective ones.

@cdce8p cdce8p added the upnext label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants