Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of steal/unborrow in tuple unpacking #18732

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

ilevkivskyi
Copy link
Member

Currently, although globally the refcount is correct, it may briefly touch 0 if a target of unpacking in unused, e.g. _, _, last = some_tuple. This can be prevented by placing steal before unborrow (which IMO should be the recommended way, if I understand the logic of these terms correctly).

Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are right. This is pretty subtle, but it appears the old logic was wrong.

@JukkaL JukkaL merged commit 34f6f6a into python:master Feb 25, 2025
12 checks passed
@ilevkivskyi ilevkivskyi deleted the fix-steal-unborrow branch February 25, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants