-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Type alias stubgen fix #18960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type alias stubgen fix #18960
Changes from 7 commits
303f01c
8c7e979
6e1bcea
3cae890
f48c3bc
0b542e9
f20b955
d6a9ff4
aa19158
1572699
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -1544,6 +1544,15 @@ from typing import TypeVar | |||||||
T = TypeVar('T') | ||||||||
alias = Union[T, List[T]] | ||||||||
|
||||||||
[case testTypeAlias] | ||||||||
from typing import TypeAlias | ||||||||
|
||||||||
alias: TypeAlias = tuple[int, str] | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fixed this, thank you |
||||||||
|
||||||||
[out] | ||||||||
alias: TypeAlias = tuple[int, str] | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't forget to add an import 👍 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @sobolevn sorry, this PR still WIP, I didn't mean to ask for a review There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No worries, marked as a draft for now :) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fixed this, thank you |
||||||||
|
||||||||
|
||||||||
[case testEllipsisAliasPreserved] | ||||||||
|
||||||||
alias = Tuple[int, ...] | ||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed this, thank you