Skip to content

[mypyc] feat: cache len for iterating over immutable types #19503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

BobTheBuidler
Copy link
Contributor

@BobTheBuidler BobTheBuidler commented Jul 25, 2025

Currently, if a user has a tuple and uses it as the sequence input for a for loop, the tuple length is checked once at each iteration which, while necessary for some container types such as list and dictionaries, is not necessary for iterating over immutable types tuple, str, and bytes.

This PR modifies the codebase such that the length is only checked at the first iteration, and reused from there.

Also, in cases where a simple genexp is the input argument for a tuple, the length is checked one additional time before entering the iteration. In those cases, we don't even need a length check at the first iteration step, and can read the result of that first len call instead.

@BobTheBuidler
Copy link
Contributor Author

Looks like my tests failed only on 32-bit python, because the generated IR uses 32-bit size numbers? Not sure what to do here, I don't think this failure is indicative of an issue in the PR.

@BobTheBuidler BobTheBuidler changed the title feat: cache len for iterating over immutable types [mypyc] feat: cache len for iterating over immutable types Jul 25, 2025
@BobTheBuidler BobTheBuidler marked this pull request as ready for review July 26, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant