Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 750: Updates requested by the Steering Council #4351

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

davepeck
Copy link
Contributor

@davepeck davepeck commented Apr 7, 2025

  • Change is either:
    • To a Draft PEP
    • To an Accepted or Final PEP, with Steering Council approval
    • To fix an editorial issue (markup, typo, link, header, etc)
  • PR title prefixed with PEP number (e.g. PEP 123: Summary of changes)

As part of pre-acceptance of PEP 750, the Steering Council requested four small updates to the PEP. I've taken a first cut at all four:

  • Specify final module location as string.templatelib
  • Spell out conv as conversion and expr as expression
  • Provide several examples of Template.__iter__()
  • Be more explicit in the section on the inability to round-trip source text
  • Possibly spell out format_spec as format_specification (TBD)
  • Edit and correct these changes

With this PR, hopefully we can all put eyes on PEP 750 and get it to a state we're excited about! 🎉


📚 Documentation preview 📚: https://pep-previews--4351.org.readthedocs.build/pep-0750/

davepeck and others added 2 commits April 7, 2025 11:21
Apply several of @AA-Turner's suggestions. Will address the remaining separately.

Co-authored-by: Adam Turner <[email protected]>
@Wingysam
Copy link

Wingysam commented Apr 7, 2025

Looks like you beat me to this! I have my own branch that does some of this locally and just saw that you've finished doing it haha.

The interpreter implementation still needs the update. I'll continue working on my fork.

@davepeck
Copy link
Contributor Author

davepeck commented Apr 7, 2025

@AA-Turner Thanks for the suggestions -- took a swing at all of them! :-)

@AA-Turner
Copy link
Member

Thank you!

A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants