Use threading.RLock for logging.Handler.lock#13390
Closed
InFiNiTy0639 wants to merge 1 commit intopython:mainfrom
InFiNiTy0639:main
Closed
Use threading.RLock for logging.Handler.lock#13390InFiNiTy0639 wants to merge 1 commit intopython:mainfrom InFiNiTy0639:main
threading.RLock for logging.Handler.lock#13390InFiNiTy0639 wants to merge 1 commit intopython:mainfrom
InFiNiTy0639:main
Conversation
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
| level: int # undocumented | ||
| formatter: Formatter | None # undocumented | ||
| lock: threading.Lock | None # undocumented | ||
| lock: threading.RLock | None # Corrected type |
Member
There was a problem hiding this comment.
I don't think the comment needs to be changed.
Member
There was a problem hiding this comment.
@InFiNiTy0639 you marked Jelle's comment as "resolved" here but it doesn't look like you addressed his feedback
threading.RLock for logging.Handler.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing Type Annotation for lock in Handler class
The type annotation for the lock attribute in the Handler class was previously incorrectly defined as threading.Lock | None in the typeshed stub. This is inconsistent with the CPython implementation, which uses threading.RLock (a reentrant lock) instead of a simple lock.
Changes made:
Reasoning: