Enable Ruff flake8-async (ASYNC) #13727
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #13295
flake8-async (ASYNC)
A handful of async-related rules that look reasonable. We happen to already respect all of them except 1: run-process-in-async-function (ASYNC221)
I followed the rule's recommendation using

anyio
for the sole reason that it's lighter thantrio
, and it's better than writing something like the followign (unless we add it to our internal lib):But I don't know what's the actual impacts, if any. Can someone else tell me if async subprocess call in async method has real benefits or if we should just ignore that rule?