Conversation
9 tasks
Collaborator
Author
|
I will split this PR tomorrow, unless someone beats me to it by reviewing the whole thing. |
Collaborator
|
Little sanity check: I verified that running ruff with |
This comment has been minimized.
This comment has been minimized.
JelleZijlstra
approved these changes
Apr 2, 2025
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
Looked at the first few files, up to asyncio
srittau
commented
Apr 2, 2025
| def get_nonlocals(self) -> tuple[str, ...]: ... | ||
|
|
||
| class Class(SymbolTable): | ||
| if sys.version_info < (3, 16): |
Collaborator
Author
There was a problem hiding this comment.
Out of scope for this PR, but I removed this check, as it's a long time to 3.16 and who knows what will happen until then.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
mmingyu
pushed a commit
to mmingyu/typeshed
that referenced
this pull request
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final part of #12112.