Enable Ruff flake8-use-pathlib (PTH) #13795
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-Ruff-flake8-use-pathlib-(PTH)
Avasam
changed the title
srittau
reviewed
Apr 4, 2025
lib/ts_utils/utils.py
Outdated
| @@ -203,7 +203,7 @@ def allowlists(distribution_name: str) -> list[str]: | |||
|
|
|||
| @functools.cache | |||
| def get_gitignore_spec() -> pathspec.PathSpec: | |||
| with open(".gitignore", encoding="UTF-8") as f: | |||
| with Path(".gitignore").open(encoding="UTF-8") as f: | |||
There was a problem hiding this comment.
I prefer the simple open() in this and similar cases. But it's no deal breaker for me. The rest looks good.
Avasam
commented
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kept this one for last. Closes #13295
Some rules in this group are forcing some refactoring to use
pathlib. In some cases, it's a lot cleaner, in others it's debatable.I unconditionally followed all the rules. Please indicate changes you disagree with/preferred in the old style. I'll revert those and disable the relevant rules.
There's also a few
with readandwith writethat can be further rewritten to be more concise withPath.read_textandPath.write_text