Skip to content

Conversation

teis-j
Copy link
Contributor

@teis-j teis-j commented Aug 15, 2025

This adds stubs for version 2.1 of the click-shell package: https://github.com/clarkperkins/click-shell

This comment has been minimized.

Copy link
Contributor

@donBarbos donBarbos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing! This package seems to be no longer supported by maintainer (last commit 4 years ago), so accepting this stubs into typeshed seems relevant.
Just a few things to correct:

Copy link
Contributor

@donBarbos donBarbos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, just few nits. And let's close the previous suggestion discussions to make it look more compact

@teis-j teis-j requested a review from donBarbos August 19, 2025 09:24
Copy link
Contributor

@donBarbos donBarbos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks much better. We just need to wait for one of the maintainers. I’ll just note that many of the Any types were simply taken from сlick type hints.
And it might be a good idea to merge main branch so that all tests can pass.

Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

discord.py (https://github.com/Rapptz/discord.py)
- discord/ext/commands/hybrid.py:508: error: Overlap between argument names and ** TypedDict items: "name", "description"  [misc]
+ discord/ext/commands/hybrid.py:508: error: Overlap between argument names and ** TypedDict items: "description", "name"  [misc]
- discord/ext/commands/hybrid.py:629: error: Overlap between argument names and ** TypedDict items: "name", "description"  [misc]
+ discord/ext/commands/hybrid.py:629: error: Overlap between argument names and ** TypedDict items: "description", "name"  [misc]

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@srittau srittau merged commit 673cecc into python:main Aug 20, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants