Skip to content

Conversation

JanEricNitschke
Copy link
Contributor

No description provided.

This comment has been minimized.

@srittau
Copy link
Collaborator

srittau commented Sep 11, 2025

Could you add your examples from #14693 to a new file stdlib/@tests/test_cases/check_turtle.py. Also, could you also fix the dot() top-level function (and copy the tests) while we're here?

@srittau srittau linked an issue Sep 11, 2025 that may be closed by this pull request
@JanEricNitschke
Copy link
Contributor Author

Merged the overloads, corrected the top level dot function and added tests.

Should i also add "failing" tests? Like a keyword argument for color (python/cpython#138772 (comment)).

Also, i didnt even know the top level dot exists. Couldnt find it in the docs and the code also doesnt obviously have it. But its created dynamically, TIL.

@JanEricNitschke JanEricNitschke marked this pull request as ready for review September 11, 2025 13:50

This comment has been minimized.

@srittau
Copy link
Collaborator

srittau commented Sep 11, 2025

Should i also add "failing" tests? Like a keyword argument for color (python/cpython#138772 (comment)).

I'll leave that to your discretion, although it can't hurt.

@JanEricNitschke
Copy link
Contributor Author

Added them. Done now from my side if you have no other comments.

Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

discord.py (https://github.com/Rapptz/discord.py)
- discord/ext/commands/hybrid.py:508: error: Overlap between argument names and ** TypedDict items: "name", "description"  [misc]
+ discord/ext/commands/hybrid.py:508: error: Overlap between argument names and ** TypedDict items: "description", "name"  [misc]
- discord/ext/commands/hybrid.py:629: error: Overlap between argument names and ** TypedDict items: "name", "description"  [misc]
+ discord/ext/commands/hybrid.py:629: error: Overlap between argument names and ** TypedDict items: "description", "name"  [misc]
- discord/ext/commands/hybrid.py:834: error: Overlap between argument names and ** TypedDict items: "name", "with_app_command"  [misc]
+ discord/ext/commands/hybrid.py:834: error: Overlap between argument names and ** TypedDict items: "with_app_command", "name"  [misc]
- discord/ext/commands/hybrid.py:858: error: Overlap between argument names and ** TypedDict items: "name", "with_app_command"  [misc]
+ discord/ext/commands/hybrid.py:858: error: Overlap between argument names and ** TypedDict items: "with_app_command", "name"  [misc]
- discord/ext/commands/hybrid.py:883: error: Overlap between argument names and ** TypedDict items: "name", "with_app_command"  [misc]
+ discord/ext/commands/hybrid.py:883: error: Overlap between argument names and ** TypedDict items: "with_app_command", "name"  [misc]
- discord/ext/commands/hybrid.py:935: error: Overlap between argument names and ** TypedDict items: "name", "with_app_command"  [misc]
+ discord/ext/commands/hybrid.py:935: error: Overlap between argument names and ** TypedDict items: "with_app_command", "name"  [misc]
- discord/ext/commands/bot.py:290: error: Overlap between argument names and ** TypedDict items: "name", "with_app_command"  [misc]
+ discord/ext/commands/bot.py:290: error: Overlap between argument names and ** TypedDict items: "with_app_command", "name"  [misc]
- discord/ext/commands/bot.py:314: error: Overlap between argument names and ** TypedDict items: "name", "with_app_command"  [misc]
+ discord/ext/commands/bot.py:314: error: Overlap between argument names and ** TypedDict items: "with_app_command", "name"  [misc]

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@srittau srittau merged commit 6937a9b into python:main Sep 11, 2025
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turtle.dot() stubs do not accurately reflect runtime signature
2 participants