-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add itertoolz.flatten #547
Open
groutr
wants to merge
17
commits into
pytoolz:master
Choose a base branch
from
groutr:flat
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
49f174b
Add itertoolz.flat
groutr 97ef2b9
Add level check.
groutr a6bf579
Add tests.
groutr 15856c9
Add flat to toolz.curried
groutr 3dd7d9b
Add newline.
groutr d5a4caf
Break line.
groutr 0e3a5f3
Add test for negative levels.
groutr 19fd366
Merge branch 'master' into flat
groutr d54b37d
Update implementation.
groutr f2abc35
Update function name.
groutr 44bd2c5
Update tests for flatten.
groutr 1c01b0a
Add newline for linter.
groutr f2a91e2
Remove extra space.
groutr a926a13
Test argument validation.
groutr 24bbff3
Add docstring for flatten.
groutr 0d58686
Mention Javascript inspiration.
groutr e1f364d
Remove trailing whitespace.
groutr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe let users pass
None
fordescend
to say "I want the default value"?This is something I almost always recommend for default arguments, especially when the default value is private, like it is here.
Because
It can help code that programmatically selects the
descend
argument.It can help with writing wrappers of
flatten
which themselves let users pass an optionaldescend
.