Improve flip to accept *args and kwargs #566
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brl0 I agree that flip is limited to two arguments and that generalizing is desirable, especially with keyword arguments. When there are two arguments, there is only one possible variation (a, b) -> (b, a). When there are more than two arguments, flip becomes ambiguous because more variations are possible. How often is it desirable to reverse the order of all of the positional arguments? Do you have a use case that this PR solves? Would the approach in #546 work for your use case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, thanks for the great project!
Currently, flip is limited to two arguments, and it does not handle keyword arguments.
I might be missing something, but this seems easy to fix, and should be a non-breaking change.
Let me know if any other changes are needed.