[ENH] Refactor progress bar backend to allow user choice#638
Open
arnavk23 wants to merge 5 commits intopytorch-tabular:mainfrom
Open
[ENH] Refactor progress bar backend to allow user choice#638arnavk23 wants to merge 5 commits intopytorch-tabular:mainfrom
arnavk23 wants to merge 5 commits intopytorch-tabular:mainfrom
Conversation
…rich - Create progress utility module with configurable backends (rich, tqdm, none) - Update config default to 'simple' and fix metadata - Make rich an optional dependency - Update all hard-coded rich imports to use the utility - Handle progress bar selection in tabular_model callbacks
fkiraly
reviewed
Feb 3, 2026
fkiraly
reviewed
Feb 3, 2026
fkiraly
reviewed
Feb 3, 2026
fkiraly
requested changes
Feb 3, 2026
Collaborator
fkiraly
left a comment
fkiraly
left a comment
There was a problem hiding this comment.
Thanks! Though, are you sure this makes rich optional? It is still being used as hard-coded option without an alternative in some places (see above)
- Change internal utilities to use 'none' backend to avoid rich dependency - Update sweep and tuner to use 'simple' instead of 'rich' when progress enabled - Refactor predict method to use progress utility instead of manual backend checks - Ensure all progress usage is configurable and doesn't force rich dependency
- Update get_progress_tracker and get_progress_context defaults from 'rich' to 'none' - Ensures no hard-coded rich usage in utility functions - Rich is now truly optional with graceful fallback
- Update fallback lambda functions to accept **kwargs to handle description and other parameters - Prevents TypeError when progress tracker is called with keyword arguments
…allback selection - Create get_progress_bar_callback() function for choosing progress bar callbacks - Refactor _prepare_callbacks to use the utility instead of manual if/elif logic - Further decouples progress bar handling from direct Lightning imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rich, investigaterichproblems #605