-
Notifications
You must be signed in to change notification settings - Fork 324
[moe training] fix scaling type bug; refactor distributed tests #2749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stack-info: PR: #2749, branch: danielvegamyhre/stack/35
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2749
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
danielvegamyhre
added a commit
that referenced
this pull request
Aug 12, 2025
stack-info: PR: #2749, branch: danielvegamyhre/stack/35
6bbb001
to
644337f
Compare
This was referenced Aug 12, 2025
644337f
to
4bf025e
Compare
vkuzo
approved these changes
Aug 15, 2025
7017c10
to
ecfa726
Compare
danielvegamyhre
added a commit
that referenced
this pull request
Aug 15, 2025
stack-info: PR: #2749, branch: danielvegamyhre/stack/35
7f77570
to
73c966c
Compare
liangel-02
pushed a commit
that referenced
this pull request
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
topic: not user facing
Use this tag if you don't want this PR to show up in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
[moe training] fix scaling type bug; refactor distributed tests
Summary
args
param consists of a list of lists, rather than a list of tensors/ScaledGroupedMMTensors. This PR fixes the issue.Test plan
pytest test/prototype/moe_training/test_training.py -s -k test_moe_float8_training -s
torchrun --local-ranks-filter=0 --nproc_per_node=8 -m pytest test/prototype/moe_training/test_fsdp.py -s
torchrun --local-ranks-filter=0 --nproc_per_node=8 -m pytest test/prototype/moe_training/test_tp.py -s
torchrun --local-ranks-filter=0 --nproc_per_node=8 -m pytest test/prototype/moe_training/test_fsdp_tp.py -s