Skip to content

Conversation

danielvegamyhre
Copy link
Contributor

@danielvegamyhre danielvegamyhre commented Aug 12, 2025

Stacked PRs:


[moe training] fix scaling type bug; refactor distributed tests

Summary

  • MoEScalingType was not getting plumbed through properly in cases where torch_dispatch args param consists of a list of lists, rather than a list of tensors/ScaledGroupedMMTensors. This PR fixes the issue.
  • Refactor our distributed tests for MoE training to align with the refactor of MoEs in torchtitan (unify moe implementation for llama4 and deepseek_v3 torchtitan#1534)

Test plan

  • pytest test/prototype/moe_training/test_training.py -s -k test_moe_float8_training -s
  • torchrun --local-ranks-filter=0 --nproc_per_node=8 -m pytest test/prototype/moe_training/test_fsdp.py -s
  • torchrun --local-ranks-filter=0 --nproc_per_node=8 -m pytest test/prototype/moe_training/test_tp.py -s
  • torchrun --local-ranks-filter=0 --nproc_per_node=8 -m pytest test/prototype/moe_training/test_fsdp_tp.py -s

stack-info: PR: #2749, branch: danielvegamyhre/stack/35
Copy link

pytorch-bot bot commented Aug 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2749

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 12, 2025
danielvegamyhre added a commit that referenced this pull request Aug 12, 2025
stack-info: PR: #2749, branch: danielvegamyhre/stack/35
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/35 branch from 6bbb001 to 644337f Compare August 12, 2025 20:23
@danielvegamyhre danielvegamyhre added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Aug 12, 2025
@danielvegamyhre
Copy link
Contributor Author

cc @vkuzo @drisspg for review of this stack

@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/34 to main August 13, 2025 04:27
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/35 branch from 644337f to 4bf025e Compare August 13, 2025 04:27
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/34 August 13, 2025 04:28
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/34 to main August 13, 2025 04:39
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/34 August 13, 2025 04:40
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/34 to main August 13, 2025 04:50
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/34 August 13, 2025 04:50
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/34 to main August 13, 2025 15:19
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/34 August 13, 2025 15:19
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/34 to main August 13, 2025 15:22
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/34 August 13, 2025 15:22
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/34 to main August 13, 2025 15:27
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/34 August 13, 2025 15:28
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/34 to main August 13, 2025 15:33
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/34 August 13, 2025 15:33
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/34 to main August 13, 2025 20:45
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/34 August 13, 2025 20:46
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/34 August 13, 2025 23:19
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/34 to main August 14, 2025 00:03
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/34 August 14, 2025 00:04
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/34 to main August 14, 2025 00:07
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/34 August 14, 2025 00:08
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/34 to main August 14, 2025 01:04
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/34 August 14, 2025 01:04
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/34 to main August 14, 2025 01:44
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/34 August 14, 2025 01:44
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/34 to main August 14, 2025 05:51
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/34 August 14, 2025 05:51
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/34 to main August 14, 2025 21:27
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/34 August 14, 2025 21:28
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/34 to main August 14, 2025 22:23
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/34 August 14, 2025 22:23
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/34 to main August 14, 2025 22:34
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/34 August 14, 2025 22:34
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/34 to main August 14, 2025 23:20
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/34 August 14, 2025 23:20
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/34 branch from 7017c10 to ecfa726 Compare August 15, 2025 16:21
danielvegamyhre added a commit that referenced this pull request Aug 15, 2025
stack-info: PR: #2749, branch: danielvegamyhre/stack/35
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/35 branch 2 times, most recently from 7f77570 to 73c966c Compare August 15, 2025 16:22
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/34 to main August 15, 2025 16:22
@danielvegamyhre danielvegamyhre merged commit 478c5f2 into main Aug 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants