Move codebook (LUT) generation methods into common utils. Update functions be more compatible with coreml. #2772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

facebook-github-bot merged 1 commit into pytorch:main from szyszyzys:export-D79595460

Aug 21, 2025

Contributor

szyszyzys commented Aug 15, 2025

Reviewed By: metascroy

Differential Revision: D79595460

pytorch-bot bot commented Aug 15, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2772

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit 71db340 with merge base 8812365 ():

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

Run 1xH100 Tests / test (H100, linux.aws.h100, --pre torch torchvision torchaudio fbgemm-gpu-genai --index-url https... / linux-job (gh) (trunk failure)
test/dtypes/test_affine_quantized_float.py::TestAffineQuantizedFloat8Compile::test_expected_kernels_on_gpu_granularity1_float8_config_version_2
Run TorchAO Experimental Tests / test-cpu-ops (linux.arm64.2xlarge) (gh) (trunk failure)
##[error]The operation was canceled.
Run TorchAO Experimental Tests / test-cpu-ops (macos-14) (gh) (trunk failure)
Process completed with exit code 1.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-cla bot added the CLA Signed label

Contributor

facebook-github-bot commented Aug 15, 2025

This pull request was exported from Phabricator. Differential Revision: D79595460

facebook-github-bot added the fb-exported label

szyszyzys force-pushed the export-D79595460 branch from 19ee361 to 7237450 Compare

August 15, 2025 20:53

szyszyzys added a commit to szyszyzys/ao that referenced this pull request


          Move codebook (LUT) generation methods into common utils. Update func…

…tions be more compatible with coreml. (pytorch#2772)

Summary: Pull Request resolved: pytorch#2772

Reviewed By: metascroy

Differential Revision: D79595460

Contributor

facebook-github-bot commented Aug 15, 2025

This pull request was exported from Phabricator. Differential Revision: D79595460

szyszyzys added a commit to szyszyzys/ao that referenced this pull request


          Move codebook (LUT) generation methods into common utils. Update func…

d441726

…tions be more compatible with coreml. (pytorch#2772)

Summary: Pull Request resolved: pytorch#2772

Reviewed By: metascroy

Differential Revision: D79595460

szyszyzys force-pushed the export-D79595460 branch 2 times, most recently from d441726 to e492a43 Compare

August 15, 2025 23:28

szyszyzys added a commit to szyszyzys/ao that referenced this pull request


          Move codebook (LUT) generation methods into common utils. Update func…

e492a43

…tions be more compatible with coreml. (pytorch#2772)

Summary: Pull Request resolved: pytorch#2772

Reviewed By: metascroy

Differential Revision: D79595460

Contributor

facebook-github-bot commented Aug 15, 2025

This pull request was exported from Phabricator. Differential Revision: D79595460

szyszyzys force-pushed the export-D79595460 branch from e492a43 to fe871fa Compare

August 15, 2025 23:32

szyszyzys added a commit to szyszyzys/ao that referenced this pull request


          Move codebook (LUT) generation methods into common utils. Update func…

fe871fa

…tions be more compatible with coreml. (pytorch#2772)

Summary: Pull Request resolved: pytorch#2772

Reviewed By: metascroy

Differential Revision: D79595460

szyszyzys force-pushed the export-D79595460 branch from fe871fa to 44350d0 Compare

August 18, 2025 16:43

szyszyzys added a commit to szyszyzys/ao that referenced this pull request


          Move codebook (LUT) generation methods into common utils. Update func…

44350d0

…tions be more compatible with coreml. (pytorch#2772)

Summary: Pull Request resolved: pytorch#2772

Reviewed By: metascroy

Differential Revision: D79595460

Contributor

facebook-github-bot commented Aug 18, 2025

This pull request was exported from Phabricator. Differential Revision: D79595460

szyszyzys added a commit to szyszyzys/ao that referenced this pull request


          Move codebook (LUT) generation methods into common utils. Update func…

51bf870

…tions be more compatible with coreml. (pytorch#2772)

Summary: Pull Request resolved: pytorch#2772

Reviewed By: metascroy

Differential Revision: D79595460

szyszyzys force-pushed the export-D79595460 branch from 44350d0 to 51bf870 Compare

August 18, 2025 16:47

szyszyzys added a commit to szyszyzys/ao that referenced this pull request


          Move codebook (LUT) generation methods into common utils. Update func…

a6ae672

…tions be more compatible with coreml. (pytorch#2772)

Summary: Pull Request resolved: pytorch#2772

Reviewed By: metascroy

Differential Revision: D79595460

szyszyzys force-pushed the export-D79595460 branch from 51bf870 to a6ae672 Compare

August 18, 2025 16:55

Contributor

facebook-github-bot commented Aug 18, 2025

This pull request was exported from Phabricator. Differential Revision: D79595460

szyszyzys added a commit to szyszyzys/ao that referenced this pull request


          Move codebook (LUT) generation methods into common utils. Update func…

90136b3

…tions be more compatible with coreml. (pytorch#2772)

Summary: Pull Request resolved: pytorch#2772

Reviewed By: metascroy

Differential Revision: D79595460

szyszyzys force-pushed the export-D79595460 branch from a6ae672 to 90136b3 Compare

August 18, 2025 16:58

metascroy approved these changes

View reviewed changes

szyszyzys force-pushed the export-D79595460 branch from 90136b3 to d237eb3 Compare

August 20, 2025 22:23

szyszyzys added a commit to szyszyzys/ao that referenced this pull request


          Move codebook (LUT) generation methods into common utils. Update func…

d237eb3

…tions be more compatible with coreml. (pytorch#2772)

Summary: Pull Request resolved: pytorch#2772

Reviewed By: metascroy

Differential Revision: D79595460

Contributor

facebook-github-bot commented Aug 20, 2025

This pull request was exported from Phabricator. Differential Revision: D79595460

szyszyzys added a commit to szyszyzys/ao that referenced this pull request


          Move codebook (LUT) generation methods into common utils. Update func…

e2cbfda

…tions be more compatible with coreml. (pytorch#2772)

Summary: Pull Request resolved: pytorch#2772

Reviewed By: metascroy

Differential Revision: D79595460

szyszyzys force-pushed the export-D79595460 branch from d237eb3 to e2cbfda Compare

August 20, 2025 22:27

Contributor

facebook-github-bot commented Aug 20, 2025

This pull request was exported from Phabricator. Differential Revision: D79595460

szyszyzys added a commit to szyszyzys/ao that referenced this pull request


          Move codebook (LUT) generation methods into common utils. Update func…

766f226

…tions be more compatible with coreml. (pytorch#2772)

Summary: Pull Request resolved: pytorch#2772

Reviewed By: metascroy

Differential Revision: D79595460

szyszyzys added a commit to szyszyzys/ao that referenced this pull request


          Move codebook (LUT) generation methods into common utils. Update func…

62e9019

…tions be more compatible with coreml. (pytorch#2772)

Summary: Pull Request resolved: pytorch#2772

Reviewed By: metascroy

Differential Revision: D79595460

szyszyzys added a commit to szyszyzys/ao that referenced this pull request


          Move codebook (LUT) generation methods into common utils. Update func…

6eaa0b2

…tions be more compatible with coreml. (pytorch#2772)

Summary: Pull Request resolved: pytorch#2772

Reviewed By: metascroy

Differential Revision: D79595460

szyszyzys added a commit to szyszyzys/ao that referenced this pull request


          Move codebook (LUT) generation methods into common utils. Update func…

a68fc97

…tions be more compatible with coreml. (pytorch#2772)

Summary: Pull Request resolved: pytorch#2772

Reviewed By: metascroy

Differential Revision: D79595460

szyszyzys added a commit to szyszyzys/ao that referenced this pull request


          Move codebook (LUT) generation methods into common utils. Update func…

803ce6f

…tions be more compatible with coreml. (pytorch#2772)

Summary: Pull Request resolved: pytorch#2772

Reviewed By: metascroy

Differential Revision: D79595460

szyszyzys added a commit to szyszyzys/ao that referenced this pull request


          Move codebook (LUT) generation methods into common utils. Update func…

4e48a25

…tions be more compatible with coreml. (pytorch#2772)

Summary: Pull Request resolved: pytorch#2772

Reviewed By: metascroy

Differential Revision: D79595460

szyszyzys added a commit to szyszyzys/ao that referenced this pull request


          Move codebook (LUT) generation methods into common utils. Update func…

002f445

…tions be more compatible with coreml. (pytorch#2772)

Summary: Pull Request resolved: pytorch#2772

Reviewed By: metascroy

Differential Revision: D79595460

szyszyzys added a commit to szyszyzys/ao that referenced this pull request


          Move codebook (LUT) generation methods into common utils. Update func…

78d2494

…tions be more compatible with coreml. (pytorch#2772)

Summary: Pull Request resolved: pytorch#2772

Reviewed By: metascroy

Differential Revision: D79595460

szyszyzys force-pushed the export-D79595460 branch from e2cbfda to 78d2494 Compare

August 20, 2025 23:47

szyszyzys added a commit to szyszyzys/ao that referenced this pull request


          Move codebook (LUT) generation methods into common utils. Update func…

02d3c10

…tions be more compatible with coreml. (pytorch#2772)

Summary: Pull Request resolved: pytorch#2772

Reviewed By: metascroy

Differential Revision: D79595460

Contributor

facebook-github-bot commented Aug 20, 2025

This pull request was exported from Phabricator. Differential Revision: D79595460

szyszyzys added a commit to szyszyzys/ao that referenced this pull request


          Move codebook (LUT) generation methods into common utils. Update func…

843727d

…tions be more compatible with coreml. (pytorch#2772)

Summary: Pull Request resolved: pytorch#2772

Reviewed By: metascroy

Differential Revision: D79595460

szyszyzys force-pushed the export-D79595460 branch from 78d2494 to 843727d Compare

August 20, 2025 23:52

szyszyzys added the topic: not user facing label

szyszyzys added a commit to szyszyzys/ao that referenced this pull request


          Move codebook (LUT) generation methods into common utils. Update func…

a3cba2b

…tions be more compatible with coreml. (pytorch#2772)

Summary: Pull Request resolved: pytorch#2772

Reviewed By: metascroy

Differential Revision: D79595460

szyszyzys force-pushed the export-D79595460 branch from 843727d to a3cba2b Compare

August 20, 2025 23:57

szyszyzys added a commit to szyszyzys/ao that referenced this pull request


          Move codebook (LUT) generation methods into common utils. Update func…

ff5865a

…tions be more compatible with coreml. (pytorch#2772)

Summary: Pull Request resolved: pytorch#2772

Reviewed By: metascroy

Differential Revision: D79595460

szyszyzys force-pushed the export-D79595460 branch from a3cba2b to ff5865a Compare

August 20, 2025 23:58

Contributor

facebook-github-bot commented Aug 20, 2025

This pull request was exported from Phabricator. Differential Revision: D79595460

1 similar comment

Contributor

facebook-github-bot commented Aug 21, 2025

This pull request was exported from Phabricator. Differential Revision: D79595460

szyszyzys added a commit to szyszyzys/ao that referenced this pull request


          Move codebook (LUT) generation methods into common utils. Update func…

ff5d3c1

…tions be more compatible with coreml. (pytorch#2772)

Summary: Pull Request resolved: pytorch#2772

Reviewed By: metascroy

Differential Revision: D79595460

szyszyzys force-pushed the export-D79595460 branch 2 times, most recently from ff5d3c1 to 92dd0b8 Compare

August 21, 2025 00:01

szyszyzys added a commit to szyszyzys/ao that referenced this pull request


          Move codebook (LUT) generation methods into common utils. Update func…

92dd0b8

…tions be more compatible with coreml. (pytorch#2772)

Summary: Pull Request resolved: pytorch#2772

Reviewed By: metascroy

Differential Revision: D79595460

Contributor

facebook-github-bot commented Aug 21, 2025

This pull request was exported from Phabricator. Differential Revision: D79595460


          Move codebook (LUT) generation methods into common utils. Update func…

71db340

…tions be more compatible with coreml. (pytorch#2772)

Summary: Pull Request resolved: pytorch#2772

Reviewed By: metascroy

Differential Revision: D79595460

szyszyzys force-pushed the export-D79595460 branch from 92dd0b8 to 71db340 Compare

August 21, 2025 00:03

Contributor

facebook-github-bot commented Aug 21, 2025

This pull request was exported from Phabricator. Differential Revision: D79595460

facebook-github-bot merged commit 706937b into pytorch:main

16 of 20 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported topic: not user facing