Skip to content

fixing torchao rocm ci test #2789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 18, 2025
Merged

fixing torchao rocm ci test #2789

merged 3 commits into from
Aug 18, 2025

Conversation

liangel-02
Copy link
Contributor

No description provided.

Copy link

pytorch-bot bot commented Aug 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2789

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 7832a99 with merge base e6b38bb (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 18, 2025
@liangel-02 liangel-02 added the topic: bug fix Use this tag for PRs that fix bugs label Aug 18, 2025
@liangel-02 liangel-02 requested a review from andrewor14 August 18, 2025 15:30
@@ -38,6 +39,7 @@ class TestInt4MarlinSparseTensor(TestCase):
def setUp(self):
self.GPU_DEVICES = ["cuda"] if torch.cuda.is_available() else []

@skip_if_rocm("ROCm enablement in progress")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it also fail in test_to_device? Maybe need to add it there too? (or move the skip to the class itself)

@liangel-02 liangel-02 marked this pull request as ready for review August 18, 2025 18:48
@liangel-02 liangel-02 merged commit 751d7f6 into main Aug 18, 2025
19 checks passed
@liangel-02 liangel-02 deleted the sparsemarlinamd branch August 18, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/rocm CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: rocm topic: bug fix Use this tag for PRs that fix bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants