Skip to content

[COMPARISON TESTS] Use pre-computed values in librosa compat test #4018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

samanklesaria
Copy link
Collaborator

This PR adds functionality for both saving files containing pre-computed values and using these precomputed values for testing that torchaudio's implementations of functionality is the same as that offered by librosa.

@samanklesaria samanklesaria requested a review from a team as a code owner August 5, 2025 16:39
Copy link

pytorch-bot bot commented Aug 5, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4018

Note: Links to docs will display an error until the docs builds have been completed.

❌ 12 New Failures

As of commit 91daa09 with merge base 0c22347 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed label Aug 5, 2025
@samanklesaria
Copy link
Collaborator Author

GPU tests are failing because CI is using an old version of numpy still.

@samanklesaria samanklesaria marked this pull request as draft August 7, 2025 14:43
@samanklesaria samanklesaria marked this pull request as ready for review August 7, 2025 19:16
@samanklesaria samanklesaria changed the title Use pre-computed values in librosa compat test [COMPARISON TESTS] Use pre-computed values in librosa compat test Aug 7, 2025
@samanklesaria samanklesaria marked this pull request as draft August 8, 2025 16:07
@samanklesaria samanklesaria marked this pull request as ready for review August 8, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants