Skip to content

[COMPARISON TESTS] Precompute values for kaldi comparison tests #4019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: librosa_mock
Choose a base branch
from

Conversation

samanklesaria
Copy link
Collaborator

To remove the kaldi dependency during testing, this PR has code to both compute files we can use for static comparisons between kaldi functionality and torchaudio functionality as well as code to use these static files to test for similar functionality when no kaldi dependency is available.

@samanklesaria samanklesaria requested a review from a team as a code owner August 5, 2025 16:41
Copy link

pytorch-bot bot commented Aug 5, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4019

Note: Links to docs will display an error until the docs builds have been completed.

❌ 10 New Failures

As of commit 1107fb9 with merge base 0c22347 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed label Aug 5, 2025
@samanklesaria samanklesaria changed the base branch from main to librosa_mock August 5, 2025 16:42
@samanklesaria
Copy link
Collaborator Author

Windows is freaking out about the filename
"test/torchaudio_unittest/assets/kaldi_expected_results/test/torchaudio_unittest/compliance/kaldi/kaldi_compatibility_cpu_test.py::TestKaldiFloat32::test_fbank_00.pt". What about this is not allowed in windows? The colons in filenames?

@samanklesaria
Copy link
Collaborator Author

I guess the natural thing to do here is to replace the colons with something else. Perhaps an underscore.

@samanklesaria samanklesaria changed the title Precompute values for kaldi comparison tests [COMPARISON TESTS] Precompute values for kaldi comparison tests Aug 7, 2025
@samanklesaria samanklesaria marked this pull request as draft August 8, 2025 16:06
@samanklesaria samanklesaria marked this pull request as ready for review August 8, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant