Skip to content

Conversation

@samanklesaria
Copy link
Collaborator

Windows tests were disabled as dependency installation was failing. Now that most dependencies are removed, we should try again.

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 20, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4059

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures

As of commit 579ee00 with merge base 0757bbb (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed label Aug 20, 2025
@pearu
Copy link
Collaborator

pearu commented Sep 2, 2025

There are lots of changes in this PR that does not match the title. Is this PR (as it is) still relevant?

@samanklesaria
Copy link
Collaborator Author

samanklesaria commented Sep 2, 2025

This PR is really just for commit [0607381]. The rest are from merges with a pseudo-main branch that was used while PRs to the main branch were bottlenecked.

@pearu pearu added this to the 2.9 milestone Sep 2, 2025
@samanklesaria
Copy link
Collaborator Author

We're getting fatal error C1083: Cannot open include file: 'torch/csrc/stable/library.h': No such file or directory 2025-09-02T21:40:26.6551037Z . Perhaps the windows build isn't using pytorch nightly?

@samanklesaria
Copy link
Collaborator Author

Now we're seeing "Cannot open include file: 'cuda_fp16.h': No such file or directory" for cuda builds.

@samanklesaria
Copy link
Collaborator Author

The CTC decoder isn't being built even for the cuda jobs. Maybe that's okay for now? I think just getting the windows tests working, even if they don't test the ctc stuff, is a good place to have this PR.

@samanklesaria
Copy link
Collaborator Author

CI is passing now! But we use conda run rather than activate. As #4085 uses the old "activate" style and also passes the tests, I will close this PR in favor of that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants