Skip to content

Conversation

DrStone71
Copy link

CUDA 13 change library and clean code of redundancy. This fix compile on Nvidia 5090 with CUDA 13.0

PLEASE NOTE THAT THE TORCHAUDIO REPOSITORY IS NO LONGER ACTIVELY MONITORED. You may not get a response. For open discussions, visit https://discuss.pytorch.org/.

CUDA 13 change library and clean code of redundancy. This fix compile on Nvidia 5090 with CUDA 13.0
@DrStone71 DrStone71 requested a review from a team as a code owner August 24, 2025 18:20
Copy link

pytorch-bot bot commented Aug 24, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4066

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link

meta-cla bot commented Aug 24, 2025

Hi @DrStone71!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

meta-cla bot commented Aug 24, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@DrStone71
Copy link
Author

thanks !!

Use #include <cuda/std/functional> is better !

@johnnynunez
Copy link

johnnynunez commented Aug 27, 2025

@DrStone71 did work for you?
i had fix more things for cuda 13

@DrStone71
Copy link
Author

@johnnynunez

pytorch vision and audio.

When i use cub::Sum,Max and Min i have fix with this @define

#if !defined(USE_ROCM) && defined(CCCL_MAJOR_VERSION) && (CCCL_MAJOR_VERSION >= 3)
#include <cuda/std/functional>
#include <cuda/functional>
using Sum_fix = cuda::std::plus<>;
using Max_fix = cuda::maximum<>;
using Min_fix = cuda::minimum<>;
#else
#include <cub/cub.cuh>
using Sum_fix = cub::Sum;
using Max_fix = cub::Max;
using Min_fix = cub::Min;
#endif

but is a wip :-(

@johnnynunez
Copy link

@johnnynunez

pytorch vision and audio.

When i use cub::Sum,Max and Min i have fix with this @define

#if !defined(USE_ROCM) && defined(CCCL_MAJOR_VERSION) && (CCCL_MAJOR_VERSION >= 3) #include <cuda/std/functional> #include <cuda/functional> using Sum_fix = cuda::std::plus<>; using Max_fix = cuda::maximum<>; using Min_fix = cuda::minimum<>; #else #include <cub/cub.cuh> using Sum_fix = cub::Sum; using Max_fix = cub::Max; using Min_fix = cub::Min; #endif

but is a wip :-(

Yes. It is happening in all repositories.
You can see here an example in sglang: https://github.com/sgl-project/sglang/pull/9495/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants