Skip to content

StaticAttentionIOManager: remove unsupported options #12931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

StaticAttentionIOManager: remove unsupported options #12931

wants to merge 1 commit into from

Conversation

sxu
Copy link
Contributor

@sxu sxu commented Jul 28, 2025

Summary:
Simplify code by removing unsupported options:

  • Storing cache transposed: not implemented doesn't seem to be a need so far.
  • Sliding cache window: cannot support local-global attention, removed.

Differential Revision: D79108366

@sxu sxu requested review from lucylq and jackzhxng as code owners July 28, 2025 22:16
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 28, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12931

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures

As of commit 54c3703 with merge base 03f6bcc (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 28, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D79108366

@sxu sxu requested review from billmguo and YIWENX14 July 28, 2025 22:17
@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@sxu @facebook-github-bot
StaticAttentionIOManager: remove unsupported options (pytorch#12931)
54c3703 
Summary:

Simplify code by removing unsupported options:
- Storing cache transposed: not implemented doesn't seem to be a need so far.
- Sliding cache window: cannot support local-global attention, removed.

Reviewed By: billmguo

Differential Revision: D79108366
@sxu sxu force-pushed the export-D79108366 branch from 5ab0a92 to 54c3703 Compare July 28, 2025 22:54
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D79108366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billmguo billmguo billmguo approved these changes

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

@jackzhxng jackzhxng Awaiting requested review from jackzhxng jackzhxng is a code owner

@YIWENX14 YIWENX14 Awaiting requested review from YIWENX14

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sxu @facebook-github-bot @billmguo