Skip to content

[Executorch][Export][3/N] Modularize export recipes #12938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

abhinaykukkadapu
Copy link
Contributor

@abhinaykukkadapu abhinaykukkadapu commented Jul 28, 2025

Stack from ghstack (oldest at bottom):

Addresses (7) in the rfc: #12660

Changes:

  1. Add data class called LoweringRecipe
  2. Modify current xnnpack recipes to use lowering recipes

Fixes: #12933

Differential Revision: D79120575

Addresses (7) in the rfc: #12660

Changes:
1. Add data class called `LoweringRecipe`
2. Modify current xnnpack recipes to use lowering recipes

Fixes: #12933

Differential Revision: [D79120575](https://our.internmc.facebook.com/intern/diff/D79120575/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Jul 28, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12938

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 20 Pending

As of commit 3bcf98e with merge base f497f7f (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

abhinaykukkadapu added a commit that referenced this pull request Jul 28, 2025
Addresses (7) in the rfc: #12660

Changes:
1. Add data class called `LoweringRecipe`
2. Modify current xnnpack recipes to use lowering recipes

Fixes: #12933

Differential Revision: [D79120575](https://our.internmc.facebook.com/intern/diff/D79120575/)

ghstack-source-id: 299106077
Pull Request resolved: #12938
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 28, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D79120575

Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Addresses (7) in the rfc: #12660

Changes:
1. Add data class called `LoweringRecipe`
2. Modify current xnnpack recipes to use lowering recipes

Fixes: #12933

Differential Revision: [D79120575](https://our.internmc.facebook.com/intern/diff/D79120575/)

[ghstack-poisoned]
abhinaykukkadapu added a commit that referenced this pull request Jul 30, 2025
Pull Request resolved: #12938

Addresses (7) in the rfc: #12660

Changes:
1. Add data class called `LoweringRecipe`
2. Modify current xnnpack recipes to use lowering recipes

Fixes: #12933

Differential Revision: [D79120575](https://our.internmc.facebook.com/intern/diff/D79120575/)
ghstack-source-id: 299637528
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D79120575

Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamping to unblock. Left some comments.

Addresses (7) in the rfc: #12660

Changes:
1. Add data class called `LoweringRecipe`
2. Modify current xnnpack recipes to use lowering recipes

Fixes: #12933

Differential Revision: [D79120575](https://our.internmc.facebook.com/intern/diff/D79120575/)

[ghstack-poisoned]
abhinaykukkadapu added a commit that referenced this pull request Jul 31, 2025
Pull Request resolved: #12938

Addresses (7) in the rfc: #12660

Changes:
1. Add data class called `LoweringRecipe`
2. Modify current xnnpack recipes to use lowering recipes

Fixes: #12933
ghstack-source-id: 299968042

Differential Revision: [D79120575](https://our.internmc.facebook.com/intern/diff/D79120575/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D79120575

Addresses (7) in the rfc: #12660

Changes:
1. Add data class called `LoweringRecipe`
2. Modify current xnnpack recipes to use lowering recipes

Fixes: #12933

Differential Revision: [D79120575](https://our.internmc.facebook.com/intern/diff/D79120575/)

[ghstack-poisoned]
abhinaykukkadapu added a commit that referenced this pull request Jul 31, 2025
Pull Request resolved: #12938

Addresses (7) in the rfc: #12660

Changes:
1. Add data class called `LoweringRecipe`
2. Modify current xnnpack recipes to use lowering recipes

Fixes: #12933
ghstack-source-id: 299976588

Differential Revision: [D79120575](https://our.internmc.facebook.com/intern/diff/D79120575/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D79120575

Addresses (7) in the rfc: #12660

Changes:
1. Add data class called `LoweringRecipe`
2. Modify current xnnpack recipes to use lowering recipes

Fixes: #12933

Differential Revision: [D79120575](https://our.internmc.facebook.com/intern/diff/D79120575/)

[ghstack-poisoned]
abhinaykukkadapu added a commit that referenced this pull request Aug 1, 2025
Pull Request resolved: #12938

Addresses (7) in the rfc: #12660

Changes:
1. Add data class called `LoweringRecipe`
2. Modify current xnnpack recipes to use lowering recipes

Fixes: #12933
ghstack-source-id: 300019402

Differential Revision: [D79120575](https://our.internmc.facebook.com/intern/diff/D79120575/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D79120575

@facebook-github-bot facebook-github-bot merged commit 3c54ad2 into gh/abhinaykukkadapu/3/base Aug 1, 2025
101 of 104 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/abhinaykukkadapu/3/head branch August 1, 2025 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants