-
Notifications
You must be signed in to change notification settings - Fork 651
Summary: Add MCU model verification to CI #13572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13572
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 10 New Failures, 3 Unrelated FailuresAs of commit 81ce0da with merge base e5f94da ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
Looks good. Kicked them off on the CI. Let's see how long the job takes else we can reduce the number of models running serially on the job or somehow run them in parallel. |
e105c8c
to
f77b37c
Compare
Looks like job passed : https://github.com/pytorch/executorch/actions/runs/17146863588/job/48644753234?pr=13572 ════════════════════════════════════════════════════════════════ lstm : ✅ Passed |
82ef97d
to
ade9974
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please resolve comments before merging.
.github/workflows/trunk.yml
Outdated
|
||
# Run MCU models | ||
chmod +x examples/arm/run_mcu_models_fvp.sh | ||
examples/arm/run_mcu_models_fvp.sh --target=ethos-u85-128 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need to have ethos targets for this script? just take cortex-m55, cortex-m85?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this involves changing build_executor_runner.sh script (which the newly added 'run_mcu_models_fvp.sh' relies on). In the build_executor_runner.sh, it has something like this
if [[ ${target} == "ethos-u55" ]]; then
target_cpu=cortex-m55
else
target_cpu=cortex-m85
fi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's do
if [[ ${target} == "cortex-m55" ]]; then
target_for_build_et_runner = "ethos-u55-128"
else ...
f4abbc9
to
5d2a173
Compare
Test Plan: OSS CI Reviewers: Subscribers: Tasks: Tags:
cpu_to_ethos_target() { | ||
local cpu=$1 | ||
case $cpu in | ||
cortex-m55) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah perfect!! ❤️
Latest run passed : https://github.com/pytorch/executorch/actions/runs/17278005534/job/49039591722?pr=13572 As a follow up ,check why removing "--use-pt-pinned-commit" is causing assertion failures while building portable kernels |
Test Plan: OSS CI
Reviewers:
Subscribers:
Tasks:
Tags:
Summary
[PLEASE REMOVE] See CONTRIBUTING.md's Pull Requests for ExecuTorch PR guidelines.
[PLEASE REMOVE] If this PR closes an issue, please add a
Fixes #<issue-id>
line.[PLEASE REMOVE] If this PR introduces a fix or feature that should be the upcoming release notes, please add a "Release notes: " label. For a list of available release notes labels, check out CONTRIBUTING.md's Pull Requests.
Test plan
[PLEASE REMOVE] How did you test this PR? Please write down any manual commands you used and note down tests that you have written if applicable.