Skip to content

Conversation

psiddh
Copy link
Contributor

@psiddh psiddh commented Aug 21, 2025

Test Plan: OSS CI

Reviewers:

Subscribers:

Tasks:

Tags:

Summary

[PLEASE REMOVE] See CONTRIBUTING.md's Pull Requests for ExecuTorch PR guidelines.

[PLEASE REMOVE] If this PR closes an issue, please add a Fixes #<issue-id> line.

[PLEASE REMOVE] If this PR introduces a fix or feature that should be the upcoming release notes, please add a "Release notes: " label. For a list of available release notes labels, check out CONTRIBUTING.md's Pull Requests.

Test plan

[PLEASE REMOVE] How did you test this PR? Please write down any manual commands you used and note down tests that you have written if applicable.

Copy link

pytorch-bot bot commented Aug 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13572

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 10 New Failures, 3 Unrelated Failures

As of commit 81ce0da with merge base e5f94da (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 21, 2025
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@psiddh psiddh marked this pull request as ready for review August 21, 2025 15:11
@digantdesai
Copy link
Contributor

Looks good. Kicked them off on the CI. Let's see how long the job takes else we can reduce the number of models running serially on the job or somehow run them in parallel.

@psiddh
Copy link
Contributor Author

psiddh commented Aug 22, 2025

Looks good. Kicked them off on the CI. Let's see how long the job takes else we can reduce the number of models running serially on the job or somehow run them in parallel.

Looks like job passed : https://github.com/pytorch/executorch/actions/runs/17146863588/job/48644753234?pr=13572

════════════════════════════════════════════════════════════════
🏁 MCU MODEL VALIDATION SUMMARY - TARGET: ethos-u85-128
════════════════════════════════════════════════════════════════

lstm : ✅ Passed
mv2 : ✅ Passed
mv3 : ✅ Passed
resnet18 : ✅ Passed

@psiddh psiddh force-pushed the mcu_trunk branch 4 times, most recently from 82ef97d to ade9974 Compare August 26, 2025 09:33
Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolve comments before merging.


# Run MCU models
chmod +x examples/arm/run_mcu_models_fvp.sh
examples/arm/run_mcu_models_fvp.sh --target=ethos-u85-128
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to have ethos targets for this script? just take cortex-m55, cortex-m85?

Copy link
Contributor Author

@psiddh psiddh Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this involves changing build_executor_runner.sh script (which the newly added 'run_mcu_models_fvp.sh' relies on). In the build_executor_runner.sh, it has something like this

if [[ ${target} == "ethos-u55" ]]; then
target_cpu=cortex-m55
else
target_cpu=cortex-m85
fi

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do

if [[ ${target} == "cortex-m55" ]]; then
   target_for_build_et_runner = "ethos-u55-128"
else ...

@psiddh psiddh force-pushed the mcu_trunk branch 2 times, most recently from f4abbc9 to 5d2a173 Compare August 26, 2025 23:25
Test Plan: OSS CI

Reviewers:

Subscribers:

Tasks:

Tags:
cpu_to_ethos_target() {
local cpu=$1
case $cpu in
cortex-m55)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah perfect!! ❤️

@psiddh
Copy link
Contributor Author

psiddh commented Aug 27, 2025

Latest run passed : https://github.com/pytorch/executorch/actions/runs/17278005534/job/49039591722?pr=13572

As a follow up ,check why removing "--use-pt-pinned-commit" is causing assertion failures while building portable kernels

@psiddh psiddh merged commit 85ec533 into main Aug 27, 2025
233 of 246 checks passed
@psiddh psiddh deleted the mcu_trunk branch August 27, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants