Skip to content

Inline requantize kernels #13592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2025
Merged

Inline requantize kernels #13592

merged 1 commit into from
Aug 26, 2025

Conversation

mcremon-meta
Copy link
Contributor

Summary: As titled. Explicit template instantiation is killing code size, so we replace all the requantize kernels with inlined dequantize/quantize, removing the need for the template instantiation.

Differential Revision: D80772740

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 22, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13592

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Unrelated Failures

As of commit ad1bcaf with merge base 3f483df (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 22, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80772740

@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80772740

mcremon-meta added a commit that referenced this pull request Aug 22, 2025
@mcremon-meta @facebook-github-bot
Inline requantize kernels (#13592)
7695fa5 
Summary:
Pull Request resolved: #13592

As titled. Explicit template instantiation is killing code size, so we replace all the requantize kernels with inlined dequantize/quantize, removing the need for the template instantiation.

Differential Revision: D80772740
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80772740

mcremon-meta added a commit that referenced this pull request Aug 25, 2025
@mcremon-meta @facebook-github-bot
Inline requantize kernels (#13592)
86fd4ef 
Summary:
Pull Request resolved: #13592

As titled. Explicit template instantiation is killing code size, so we replace all the requantize kernels with inlined dequantize/quantize, removing the need for the template instantiation.

Reviewed By: ethansfng

Differential Revision: D80772740
@mcremon-meta @facebook-github-bot
Inline requantize kernels (#13592)
ad1bcaf 
Summary:
Pull Request resolved: #13592

As titled. Explicit template instantiation is killing code size, so we replace all the requantize kernels with inlined dequantize/quantize, removing the need for the template instantiation.

Reviewed By: ethansfng

Differential Revision: D80772740
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80772740

@facebook-github-bot facebook-github-bot merged commit 53555b3 into main Aug 26, 2025
106 of 113 checks passed
@facebook-github-bot facebook-github-bot deleted the export-D80772740 branch August 26, 2025 02:28
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
@mcremon-meta @agrima1304
Inline requantize kernels
80d1407 
Differential Revision: D80772740

Pull Request resolved: pytorch#13592
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethansfng ethansfng ethansfng approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcremon-meta @facebook-github-bot @ethansfng