-
Notifications
You must be signed in to change notification settings - Fork 662
Fix build on Windows, re-enable Windows build CI job #13672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13672
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 2 Unrelated FailuresAs of commit 3a32779 with merge base 7dab7c1 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
CMakeLists.txt
Outdated
PATTERN "*.h" | ||
PATTERN ${data_loader_exclude_pattern} EXCLUDE | ||
) | ||
if (DEFINED data_loader_exclude_pattern) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@swolchok It looks like CMake complains when there's an exclude with an empty pattern (see https://github.com/pytorch/executorch/actions/runs/17222786697/job/48861521892, line 818). This is a bit of a pain as there doesn't seem to be an elegant solution to this. Do you have any preferences on this approach?
I suppose we could default the exclude pattern to some string that matches nothing, though that seems a little hacky. It looks like we could also maybe build a list of install args, including the "magic" keywords, though I haven't tried it.
The Windows CI build job was disabled in #13669 due to a new Windows build failure in #13485. Since that diff was reverted in #13685, we can re-enable the job. I started fixing the issue in #13672, but dropped it due to the revert. It's a simple change, so it can likely be bundled when the affected PR is re-landed. Test Plan: The Build Preset / Windows job is passing on this PR.
CMake doesn't seem to like empty exclude patterns.