Skip to content

Conversation

wwwind
Copy link
Collaborator

@wwwind wwwind commented Oct 3, 2025

Correct implementation of div.tensor_mode for 'floor' case to make it numerically stable.

Change-Id: I6e76bab3528c7b05f7710f6a402791c5b682aee3
Signed-off-by: Elena Zhelezina [email protected]

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

… stable

Change-Id: I6e76bab3528c7b05f7710f6a402791c5b682aee3
Signed-off-by: Elena Zhelezina <[email protected]>
@wwwind wwwind requested a review from digantdesai as a code owner October 3, 2025 12:02
Copy link

pytorch-bot bot commented Oct 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14776

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 2 Unrelated Failures

As of commit 5fa4025 with merge base fb87fa6 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 3, 2025
@wwwind wwwind requested review from zingo and removed request for digantdesai October 3, 2025 12:03
@wwwind wwwind added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Oct 3, 2025
Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zingo
Copy link
Collaborator

zingo commented Oct 7, 2025

Hi @wwwind this seem to fail for Ethos-U55

FAILED backends/arm/test/ops/test_div_tensor_mode.py::test_div_tensor_mode_u55_INT[mode_floor] - RuntimeError: Corstone simulation failed:
FAILED backends/arm/test/ops/test_div_tensor_mode.py::test_div_tensor_mode_u55_INT[op_floor_div_rank4_large_randn] - RuntimeError: Corstone simulation failed:

wwwind added 2 commits October 7, 2025 10:21
Change-Id: I4569bbd8f317eb73dab634320ebcf72593adbc93
@wwwind
Copy link
Collaborator Author

wwwind commented Oct 7, 2025

Thank you @zingo I pushed a fix

wwwind added 4 commits October 7, 2025 13:19
Change-Id: I4707f3aa7155a121b0e721f2f344e6c10f330692
Change-Id: I2d89bfecadfc2ec137ecd3c87e728a16b2fc6832
@zingo
Copy link
Collaborator

zingo commented Oct 8, 2025

fails are unrelated

@zingo zingo merged commit 7d2b8c6 into pytorch:main Oct 8, 2025
283 of 286 checks passed
ArmRyan added a commit that referenced this pull request Oct 10, 2025
zingo pushed a commit that referenced this pull request Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants