Skip to content

Conversation

@novak-vaclav
Copy link
Contributor

@novak-vaclav novak-vaclav commented Jan 7, 2026

Summary

adds support for aten.split operator

Test plan

tests can be manually run using pytest -c /dev/null backends/nxp/tests/

cc @robert-kalmar @JakeStevens @digantdesai @MartinPavella

Copilot AI review requested due to automatic review settings January 7, 2026 16:05
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 7, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16490

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 1 Unrelated Failure

As of commit 3016a50 with merge base 0391fe7 (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 7, 2026
@novak-vaclav
Copy link
Contributor Author

@pytorchbot label "release notes: nxp"

@novak-vaclav
Copy link
Contributor Author

@pytorchbot label "module: nxp"

@pytorch-bot pytorch-bot bot added release notes: nxp Changes to the NXP Neutron backend delegate module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ labels Jan 7, 2026
@novak-vaclav
Copy link
Contributor Author

Fixed all issues mentioned in this PR (#16276), including the comment of @roman-janik-nxp
But due to my error I had to create a new PR.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the aten.split operator in the NXP backend by introducing a new pass that decomposes split operations into slice operations. The key addition is the DecomposeSplitToSlicesPass, which transforms aten.split.Tensor, aten.split.default, and aten.split_with_sizes.default operations into equivalent aten.slice.Tensor operations that the backend can handle.

Key changes:

  • Added DecomposeSplitToSlicesPass to decompose split operations into slices
  • Removed ConvertUnsqueezeToViewPass from the default pass manager
  • Added test models (SplitWithSize, SplitWithSections, GRUModel) to support split testing
  • Introduced comprehensive tests for the new decomposition pass

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
backends/nxp/aten_passes/decompose_split_to_slices_pass.py New pass that decomposes split operations into multiple slice operations for backend compatibility
backends/nxp/aten_passes/neutron_aten_pass_manager.py Added DecomposeSplitToSlicesPass to default passes and removed ConvertUnsqueezeToViewPass import
backends/nxp/tests/test_decompose_split_to_slices.py Comprehensive test suite for the new split decomposition pass
backends/nxp/tests/models.py Added test models (GRUModel, SplitWithSize, SplitWithSections) to support split operation testing
backends/nxp/tests/test_split_group_convolution.py Added workaround to exclude DecomposeSplitToSlicesPass from affecting group convolution tests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@novak-vaclav novak-vaclav force-pushed the feature/EIEX-374-add-support-for-split branch from abb63f7 to 72f82ff Compare January 12, 2026 08:24
Copilot AI review requested due to automatic review settings January 12, 2026 08:32
@novak-vaclav novak-vaclav force-pushed the feature/EIEX-374-add-support-for-split branch from 72f82ff to 3016a50 Compare January 12, 2026 08:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MartinPavella MartinPavella merged commit 6d25df6 into pytorch:main Jan 12, 2026
143 of 149 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants