Skip to content

Conversation

@GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Jan 16, 2026

Summary: In D89086669, we updated StagingBuffer to take a flag specifying transfer direction (CPU->GPU or GPU->CPU). I missed the call sites under tools/gpuinfo. This PR updates these call sites to make the tool buildable again.

Differential Revision: D90888995

cc @SS-JIA @manuelcandales @digantdesai @cbilgin

Summary: In D89086669, we updated StagingBuffer to take a flag specifying transfer direction (CPU->GPU or GPU->CPU). I missed the call sites under tools/gpuinfo. This PR updates these call sites to make the tool buildable again.

Differential Revision: D90888995
@GregoryComer GregoryComer requested a review from SS-JIA as a code owner January 16, 2026 21:34
@pytorch-bot pytorch-bot bot added the module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ label Jan 16, 2026
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 16, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16664

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Unrelated Failures

As of commit ca9705a with merge base b4b7837 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-codesync
Copy link
Contributor

meta-codesync bot commented Jan 16, 2026

@GregoryComer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90888995.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 16, 2026
@GregoryComer GregoryComer changed the title Update vulkan gpuinfo code for staging buffer changes [ET-VK] Update vulkan gpuinfo code for staging buffer changes Jan 16, 2026
@GregoryComer GregoryComer added the release notes: none Do not include this in the release notes label Jan 16, 2026
@meta-codesync
Copy link
Contributor

meta-codesync bot commented Jan 16, 2026

@GregoryComer has imported this pull request. If you are a Meta employee, you can view this in D90888995.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant