NOCOMMIT: PoC: vectorize just expm1 #9586
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9586
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Cancelled JobAs of commit 6c7c0e6 with merge base 644b7dd ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Mar 25, 2025
Merged
swolchok
added a commit
that referenced
this pull request
Mar 25, 2025
Here is how we can vectorize expm1 given the prior PRs in this stack. It is NOCOMMIT because we actually should implement vectorization for all the `unary_ufunc_*` ops. ghstack-source-id: 94797d60df66089ebda3321a525d8a707be830f2 ghstack-comment-id: 2751961712 Pull Request resolved: #9586
facebook-github-bot
added
the
CLA Signed
swolchok
added a commit
that referenced
this pull request
Mar 25, 2025
Here is how we can vectorize expm1 given the prior PRs in this stack. It is NOCOMMIT because we actually should implement vectorization for all the `unary_ufunc_*` ops. ghstack-source-id: 94797d60df66089ebda3321a525d8a707be830f2 ghstack-comment-id: 2751961712 Pull Request resolved: #9586
swolchok
added a commit
that referenced
this pull request
Mar 25, 2025
Here is how we can vectorize expm1 given the prior PRs in this stack. It is NOCOMMIT because we actually should implement vectorization for all the `unary_ufunc_*` ops. ghstack-source-id: e65c2b075587f716b8a746616d3335bab69a261d ghstack-comment-id: 2751961712 Pull Request resolved: #9586
swolchok
added a commit
to swolchok/ghstack
that referenced
this pull request
Mar 25, 2025
I ran into an issue reordering diffs in a direct stack (the one currently ending in pytorch/executorch#9586) where GitHub's API complained `There are no new commits between base branch 'gh/swolchok/395/head' and head branch 'gh/swolchok/383/head'`. This seems to have fixed it for me.
swolchok
added a commit
to swolchok/ghstack
that referenced
this pull request
Mar 27, 2025
I ran into an issue reordering diffs in a direct stack (the one currently ending in pytorch/executorch#9586) where GitHub's API complained `There are no new commits between base branch 'gh/swolchok/395/head' and head branch 'gh/swolchok/383/head'`. This seems to have fixed it for me.
ezyang
pushed a commit
to ezyang/ghstack
that referenced
this pull request
Mar 28, 2025
I ran into an issue reordering diffs in a direct stack (the one currently ending in pytorch/executorch#9586) where GitHub's API complained `There are no new commits between base branch 'gh/swolchok/395/head' and head branch 'gh/swolchok/383/head'`. This seems to have fixed it for me.
swolchok
commented
Apr 2, 2025
| #include <executorch/runtime/kernel/kernel_includes.h> | ||
| #include <cmath> | ||
|
|
||
| namespace torch { | ||
| namespace executor { | ||
| namespace native { | ||
|
|
||
| // REVIEW: I'm not entirely sure what the best way to implement this |
There was a problem hiding this comment.
either the original vectorization PR or a preliminary PR will address this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is how we can vectorize
expm1given the prior PRs in this stack. It is NOCOMMIT because we actually should implement vectorization for all theunary_ufunc_*ops.