Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save some size in dtype_util when dtype selective build is not in use #9829

Closed
wants to merge 1 commit into from

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Apr 2, 2025

We duplicate a lot of functions depending on the operator name so that dtype selective build will work. We can just detect if dtype selective build is in use and, if not, stop duplicating.

Test Plan: Saves 28288 bytes of text in size_test_all_optimized_ops compared to previous PR on my Mac.
Pull-Request-resolved: #9742

[ghstack-poisoned]
@swolchok swolchok requested a review from manuelcandales as a code owner April 2, 2025 02:33
Copy link

pytorch-bot bot commented Apr 2, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9829

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ef74fe1 with merge base 5fcb6b8 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@swolchok
Copy link
Contributor Author

swolchok commented Apr 2, 2025

ugh, ghstack seems to have duplicated a ton of PRs in this stack

@swolchok
Copy link
Contributor Author

swolchok commented Apr 2, 2025

duplicate PR

@swolchok swolchok closed this Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants