1 regression tests available device #3335 #3403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al_bias.py, test_geometric_mean_absolute_error.py
…onal_bias.py test_geometric_mean_absolute_error.py
vfdev-5
reviewed
May 3, 2025
vfdev-5
reviewed
May 3, 2025
vfdev-5
reviewed
May 3, 2025
| (torch.rand(size=(100, 1)), torch.rand(size=(100, 1)), 20), | ||
| ] | ||
| return test_cases | ||
| np_sum = (2 * np.abs(np_y_pred - np_y) / (np.abs(np_y_pred) + np.abs(np_y))).sum() |
There was a problem hiding this comment.
Let's use torch everywhere such that we could also remove import numpy as np
There was a problem hiding this comment.
done, but numpy is still used in _test_distrib_compute
There was a problem hiding this comment.
You can do the same there: error = 2 * torch.abs(pred - ground_truth) / (torch.abs(pred) + torch.abs(ground_truth))
There was a problem hiding this comment.
sure, but wouldn't it make more sense to do a separate PR to do a pass on distributed tests?
vfdev-5
reviewed
May 3, 2025
tests/ignite/metrics/regression/test_geometric_mean_absolute_error.py
Outdated
Show resolved
Hide resolved
vfdev-5
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_canberra_metric.py
test_fractional_absolute_error.py
test_fractional_bias.py
test_geometric_mean_absolute_error.py